Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get bytes of semantic values too? #64

Open
Gankra opened this issue Jul 7, 2024 · 1 comment
Open

get bytes of semantic values too? #64

Gankra opened this issue Jul 7, 2024 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@Gankra
Copy link
Owner

Gankra commented Jul 7, 2024

In #57 and #62 we moved from treating bool and enums as primitives with bytes to semantic values that can only be checked with patterns/ifs. This is good in terms of the harness not making up garbage values for "expect" and clean clear output, but it would be nice if we got the bytes of them too since often an ABI corruption will write forbidden values that don't make sense.

Right now this is tricky to do because the harness believes each "value" (field) can only have one payload (bytes). This would result in enums and bools having two payloads: the semantic tag, and the raw bytes.

@Gankra Gankra added enhancement New feature or request question Further information is requested labels Jul 7, 2024
@Gankra
Copy link
Owner Author

Gankra commented Jul 7, 2024

Note that the original semantic values -- (tagged/untagged) union variants -- are not eligible for this. they are truly purely semantic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant