-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always popover #17
Always popover #17
Conversation
Bmichotte conflict
I also corrected some tests which failed in localized iDevice |
Some of those corrected tests were included in my PR #13 that's already been merged. Looks like you need a rebase here before we can merge :) |
I think it should be ok like this |
Loons good on my end. Maybe we should add an iPad spec build line to the travis file so we're getting full test coverage? |
Also... Wondering if we should also optionally support |
This looks near done. I'm thinking we need mark's suggested travis ci spec change for this PR, and merge it. (Proper testing) love the arrow_directions add! |
Here are the arrow_direction option ;) |
Awesome! Thanks so much for this contribution! |
I think I'll merge this and solve the iPad tests issue in master real quick. :) |
Tests pass on iPad Air! |
👍 |
Relative to #11
This PR force the use of popover when on iPad.
I changed the functionality with the following
If you want to present your alert in :sheet style and you are on iPad, you have to provide the
:source
for the popover (either a UIView or a UIBarButtonItem)You can also provide a
:modal
option if you want the popover to be modal. This option is only available for iOS 8+.I have updated all tests to work on iPhone and iPad