Skip to content
This repository has been archived by the owner on Aug 28, 2021. It is now read-only.

add the ability to download direct url if not hls #77

Merged
merged 3 commits into from
Jul 6, 2020
Merged

add the ability to download direct url if not hls #77

merged 3 commits into from
Jul 6, 2020

Conversation

CT1994
Copy link
Contributor

@CT1994 CT1994 commented Jul 5, 2020

this is to fix the issue where the filename is not the expected format of hd{sourceIndex}.mp4

@CT1994
Copy link
Contributor Author

CT1994 commented Jul 5, 2020

@imaginebreake here is the fix for the issue you raised

@breakertt
Copy link
Member

Test passed, please merge @ericjiang97 .
@CT1994 Thank you!

@CT1994
Copy link
Contributor Author

CT1994 commented Jul 5, 2020

@imaginebreake could you retest I have also fixed the following issue
https://github.com/GeckoDM/GeckoDownloadManager/issues/72

@hugobene
@sethb3744
@ericjiang97

Copy link
Member

@ericjiang97 ericjiang97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@CT1994
Copy link
Contributor Author

CT1994 commented Jul 5, 2020

@ericjiang97 I've done a small cleanup where i did not like picking the script tag out of the html page so i filter to find the data i am looking for

@ericjiang97 ericjiang97 merged commit ae5e464 into GeckoDM:master Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants