Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] TouchableNativeFeedback should also be used when Platform.Version === 21 && Platform.OS !== 'ios'? #1580

Closed
ming436534 opened this issue Feb 12, 2018 · 4 comments
Closed

[Button] TouchableNativeFeedback should also be used when Platform.Version === 21 && Platform.OS !== 'ios'? #1580

ming436534 opened this issue Feb 12, 2018 · 4 comments

Comments

@ming436534
Copy link

ming436534 commented Feb 12, 2018 •
edited
Loading

react-native, react and native-base version

Version:
react-native: 0.52.0
react: 16.2.0
native-base: 2.3.8
Android Version: API level 21

Expected behaviour

Button has ripple

Actual behaviour

Button has no ripple on Press

According to android doc, ripple animation was added in API level 21, is there any reason native base only support use TouchableNativeFeedback when android API level > 21?
@ming436534 ming436534 changed the title Android button ripple should also support Platform === 21 ? [Button] TouchableNativeFeedback should also be used Platform.Version === 21 && Platform.OS !== 'ios'? Feb 12, 2018
@ming436534 ming436534 changed the title [Button] TouchableNativeFeedback should also be used Platform.Version === 21 && Platform.OS !== 'ios'? [Button] TouchableNativeFeedback should also be used when Platform.Version === 21 && Platform.OS !== 'ios'? Feb 12, 2018
@SupriyaKalghatgi
Copy link
Contributor

@ming436534 Yes! NativeBase supports TouchableNativeFeedback with Android API > 21

@ming436534
Copy link
Author

I guess NativeBase should also support TouchableNativeFeedback with Android API = 21?

@SupriyaKalghatgi
Copy link
Contributor

@ming436534 yes, that does
check the commit file completely

@SupriyaKalghatgi
Copy link
Contributor

Fixed with 2.3.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SupriyaKalghatgi @ming436534