Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons "active" styling doesn't work #1587

Closed
flxwu opened this issue Feb 14, 2018 · 10 comments
Closed

Buttons "active" styling doesn't work #1587

flxwu opened this issue Feb 14, 2018 · 10 comments

Comments

@flxwu
Copy link

flxwu commented Feb 14, 2018

I tried the Footer with only icons example from the docs, which should show the navigation icon as the only active button.
But for me, all buttons are shown active - What's the issue?

react-native, react and native-base version

  • react-native-cli: 2.0.1
  • react-native: 0.50.4
  • react: 16.0.0
  • native-base: ^2.3.8

Expected behaviour

Only the navigation button should be active.
Like this:
2018-02-14_13_47_58

Actual behaviour

All buttons in the tabbar are shown active, as seen in the screenshot.

Steps to reproduce (code snippet or screenshot)

      <Footer>
        <FooterTab>
          <Button>
            <Icon name="apps" />
          </Button>
          <Button>
            <Icon name="camera" />
          </Button>
          <Button active>
            <Icon active name="navigate" />
          </Button>
          <Button>
            <Icon name="person" />
          </Button>
        </FooterTab>
      </Footer>

Screenshot of emulator/device

Screenshot

Is the bug present in both ios and android or in any one of them?

My device is a Huawei P8 running Android 6.1.

@SupriyaKalghatgi
Copy link
Contributor

@pl4gue Can you upload screenshot of emulator / device?

@SupriyaKalghatgi
Copy link
Contributor

@pl4gue Tried your code snippet

<Footer>
  <FooterTab>
    <Button>
      <Icon name="apps" />
    </Button>
    <Button>
      <Icon name="camera" />
    </Button>
    <Button active>
      <Icon active name="navigate" />
    </Button>
    <Button>
      <Icon name="person" />
    </Button>
  </FooterTab>
</Footer>

And the output is here for Android and iOS

Worked as expected

@flxwu
Copy link
Author

flxwu commented Feb 15, 2018

I added the screenshot of my device @SupriyaKalghatgi

@flxwu
Copy link
Author

flxwu commented Feb 15, 2018

Yeah that's how it should work. But does not look like this on my device. @SupriyaKalghatgi

@SupriyaKalghatgi
Copy link
Contributor

@pl4gue The screenshot that you uploaded in issue description for Screenshot of emulator/device is broken

Yesterday I asked you to upload same

@flxwu
Copy link
Author

flxwu commented Feb 16, 2018

Why is it still broken... -_- I will try again later

@SupriyaKalghatgi
Copy link
Contributor

@pl4gue Later? If that takes time, then you can close the issue
Since we presented you working snippet with desired output

@flxwu
Copy link
Author

flxwu commented Feb 16, 2018

screenshot_2018-02-14-13-43-10
This is actually what it looks like on my device @SupriyaKalghatgi

@SupriyaKalghatgi
Copy link
Contributor

Fixed with NB 2.3.10

@Alarees
Copy link

Alarees commented Mar 29, 2020

hi,
i have the same problem
i using NB:2.13.8, RN:0.61.5
using emulator android 5.1
PS : i'm not using footer

            <View >
              <Button active >
                <Icon active name='md-call' >
              </Button>
            </View>
            <View >
              <Button >
                <Icon name='md-call' >
              </Button>
            </View>
            <View >
              <Button >
                <Icon name='md-call' >
              </Button>
            </View>

@SupriyaKalghatgi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants