Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caldb add does not warn when trying to add an unsupported file #441

Open
KathleenLabrie opened this issue Jul 5, 2023 · 0 comments
Open
Labels
enhancement Performance or usage improvement severity-routine Needs to be fixed urgency-low Do when we have a breather usage Usage and user interfaces

Comments

@KathleenLabrie
Copy link
Contributor

When trying to caldb add a user BPM, nothing happens. caldb add does not add the user BPM. This is good, that is the desired behavior (I have evidence that it is the desired behavior and this is not the point of this ticket). The issue is that it should warn the user that it did not add it because it isn't a recognized calibration.

There's a BPM, produced with NIRI's makeProcessedBPM here:
https://drive.google.com/drive/folders/1ByrpK3NlPgfBchraFbUKYW0SAU_s3FVP?usp=sharing

Set up a calibration DB in dragonsrc and init it. Then:

$ caldb add N20160102S0373_bpm.fits
$ caldb list

It has not added it, good. But it has not complained about it either, bad.

I would expect a warning along the lines of: "WARNING: N20160102S0373_bpm.fits is not a recognized calibration, not addind to the calibration database."

@KathleenLabrie KathleenLabrie added enhancement Performance or usage improvement severity-routine Needs to be fixed urgency-low Do when we have a breather usage Usage and user interfaces labels Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Performance or usage improvement severity-routine Needs to be fixed urgency-low Do when we have a breather usage Usage and user interfaces
Projects
None yet
Development

No branches or pull requests

1 participant