Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tracing algorithm #448

Open
chris-simpson opened this issue Apr 4, 2024 · 0 comments
Open

Improve tracing algorithm #448

chris-simpson opened this issue Apr 4, 2024 · 0 comments

Comments

@chris-simpson
Copy link
Contributor

The tracing algorithm expects each trace to be nearly vertical, which isn't always the case. If there's a significant region where the trace is lost, it can fail to find it on the other side because it only tries to find a peak around the last position. With pinhole masks (or close sources) it's possible that another trace might be closer to this position than the correct trace.

A suggested solution is to create Trace objects which store the coordinates along a trace, probably in a deque and have a method with extrapolates the last 2 or 3 points to determine a better estimate of the trace location. This should improve the readability of the code as well, instead of juggling various lists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant