Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLAlchemy update 1.4 -> 2.0 #43

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

SQLAlchemy update 1.4 -> 2.0 #43

wants to merge 37 commits into from

Conversation

teald
Copy link
Member

@teald teald commented Jul 10, 2024

Resolves issue #39

Status

This currently passes:

  • code_tests

It will require more testing before being merged in.

Changes

  • Followed migration guide to update SQLAlchemy to use the v2 API (see SQLAlchemy 1.4 -> 2.0 Update #39).
  • Updates requirements.txt
  • (❓) Add code testing with nox
  • (❓) Add requirement_dev.txt (contains some top-level, non-development dependencies at the moment)

❓-> Added, but can be removed before merging. These are for my own convenience.

Migration info/todo

See Issue #39 for details.

teald added 28 commits July 10, 2024 14:11
Instead, it is accessed through session.get(to_be_queried, key).
Changes most of the `relation` calls to `relationship` calls per the
warning messages. However, this causes at least one error due to a
nuance in how `relation` works, it seems, and that needs to be
diagnosed.
This non-sql related update catches the base exception caught in
FileOpser.fileop and adds its message to the FileOpser.doerror message.

This is mainly for convenience with updating, and can be omitted later
if desired.
This overrides SQLAlchemy's declarative_base in both instances when
creating the declarative base class.
@teald teald added the enhancement New feature or request label Jul 10, 2024
@teald teald requested a review from phirstgemini July 10, 2024 21:21
@teald teald linked an issue Jul 10, 2024 that may be closed by this pull request
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQLAlchemy 1.4 -> 2.0 Update
2 participants