Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flexibility to generated quantities #288

Closed
1 of 3 tasks
gowerc opened this issue Mar 22, 2024 · 0 comments · Fixed by #294
Closed
1 of 3 tasks

Add flexibility to generated quantities #288

gowerc opened this issue Mar 22, 2024 · 0 comments · Fixed by #294
Assignees
Labels
enhancement New feature or request

Comments

@gowerc
Copy link
Collaborator

gowerc commented Mar 22, 2024

The current implementation of the generated quantities functions allows the users to provide a list of patients and a time grid as 2 independent arguments. The functions then predict the values for all patients at the given time grid.

Unfortunately this doesn't quite meet two common use cases which would be:

  • Predict just at the observed time points for each patient (which is different per patient)
  • Predict at say X evenly spaced intervals between 0 and the patients event time

I think we potentially need 3 changes

  • Generalise the looping mechanism in the generated quantities to avoid each model having to re-implement the same logic
  • Allow user arguments to generated quantities to specify different time points per subject
  • Have helper objects / functions to setup the per patient grids as specified above
@gowerc gowerc added the enhancement New feature or request label Mar 22, 2024
@gowerc gowerc self-assigned this Mar 22, 2024
@gowerc gowerc added this to the Initial Internal Release milestone Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant