Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prior parameters supplied as data #234

Merged
merged 7 commits into from
Oct 13, 2023
Merged

Prior parameters supplied as data #234

merged 7 commits into from
Oct 13, 2023

Conversation

gowerc
Copy link
Collaborator

@gowerc gowerc commented Oct 12, 2023

Closes #106

Is feature complete but still need to do docs + tests so currently WIP

@gowerc gowerc changed the title WIP - Prior parameters supplied as data Prior parameters supplied as data Oct 12, 2023
@gowerc gowerc marked this pull request as ready for review October 12, 2023 14:48
@gowerc
Copy link
Collaborator Author

gowerc commented Oct 12, 2023

@danielinteractive - Pending on cicd failures this is now ready for review. Note as always most of the files changed are just docs due to the use of @family

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  ----------------------
R/DataJoint.R                     56       0  100.00%
R/DataLongitudinal.R             100       1  99.00%   245
R/DataSubject.R                   52       1  98.08%   123
R/DataSurvival.R                  55       1  98.18%   145
R/defaults.R                      13       7  46.15%   27, 45-84, 111
R/generics.R                      14       1  92.86%   69
R/JointModel.R                    62       5  91.94%   113-125
R/JointModelSamples.R             23       0  100.00%
R/Link.R                           6       0  100.00%
R/LinkGSF.R                       63      12  80.95%   109-120
R/LinkNone.R                       3       1  66.67%   36
R/LinkRandomSlope.R               10       0  100.00%
R/LongitudinalGSF.R               23       0  100.00%
R/LongitudinalModel.R             10       0  100.00%
R/LongitudinalQuantities.R        71       8  88.73%   89-96
R/LongitudinalRandomSlope.R       21       0  100.00%
R/Parameter.R                     10       0  100.00%
R/ParameterList.R                 28       0  100.00%
R/Prior.R                        100      20  80.00%   55-61, 198-210
R/Quantities.R                    89       0  100.00%
R/simulations_gsf.R               43       0  100.00%
R/simulations_os.R                11       5  54.55%   35-39
R/simulations_rs.R                21       0  100.00%
R/simulations.R                   99       1  98.99%   122
R/StanModel.R                      6       0  100.00%
R/StanModule.R                   145       5  96.55%   197-198, 214, 251, 262
R/SurvivalExponential.R            9       0  100.00%
R/SurvivalLoglogistic.R           10      10  0.00%    31-40
R/SurvivalModel.R                 12       0  100.00%
R/SurvivalQuantities.R           103       6  94.17%   161-166
R/SurvivalWeibullPH.R             10       0  100.00%
R/utilities.R                    145       1  99.31%   13
R/zzz.R                           11      11  0.00%    4-29
TOTAL                           1434      96  93.31%

Diff against main

Filename                       Stmts    Miss  Cover
---------------------------  -------  ------  --------
R/JointModel.R                    +3       0  +0.41%
R/JointModelSamples.R             +3       0  +100.00%
R/LongitudinalRandomSlope.R       +4      -1  +5.88%
R/Parameter.R                     -1       0  +100.00%
R/ParameterList.R                 +1       0  +100.00%
R/Prior.R                        +37      +5  +3.81%
TOTAL                            +47      +4  -0.06%

Results for commit: e412841

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

Unit Tests Summary

    1 files    27 suites   6m 40s ⏱️
  63 tests   61 ✔️ 2 💤 0
279 runs  277 ✔️ 2 💤 0

Results for commit e412841.

♻️ This comment has been updated with latest results.

R/DataJoint.R Outdated Show resolved Hide resolved
@gowerc gowerc merged commit 62a9172 into main Oct 13, 2023
21 checks passed
@gowerc gowerc deleted the feature/data_prior branch October 13, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert priors to be input data to avoid unnecesary model compilation
2 participants