-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-factored the stan code for longitudinal generated quantities #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Tests Summary 1 files 40 suites 5m 30s ⏱️ Results for commit f5a0403. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 835c5b9 ♻️ This comment has been updated with latest results. |
Code Coverage Summary
Diff against main
Results for commit: f5a0403 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
danielinteractive
previously approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part 1 of #288
In this PR I factor out the looping code into the base longitudinal model stan file. This means each individual model doesn't have to concern itself about how patients are subset meaning less chance of issues in the future when we update this mechanism.
We then introduce a new interface that the longitudinal models have to conform to which is that they must create a function with signature:
They also must define a matrix
long_gq_parameters
which has 1 row per patient and as many columns as required for the model in question. As an example for the SF model this is defined as:I also added a new unit test to show that patient subsetting works as expected and that the correct values are reconstructed per each sample per patient.