-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add illustration to complicated module options #7911
Comments
Just one thought here, adding more images is definitely a good idea, but it will also significantly increase the number of tests, which will slow down the testing process. For example, the image for the 35 PostScript fonts (https://docs.generic-mapping-tools.org/dev/_images/GMT_App_G.png) never changes and should always pass. Sometimes it fails because tiny differences caused by different gs versions but we really don't care about it. So it's not necessary to test it. In other words, we should have a mechanism to skip a test, e.g., adding |
Well, I'm willing to write some. Can you make a somewhat prioritized list? Do you want them to be one-liners or within |
Thanks. I dont have a list. I think it words best if there is a particular option that is too nebulous to you and could benefit from a sketch or plot. I am sensitive to @seisman's point but unlike most of the tests these scripts actually produce a figure in the documentation and even allows users to see the script that made it. To the extent possible, show around for something in the test/module directory. If it does not have exactly what you need then you can add to it or it is a new script (which goes in doc/scripts). Don't worry about the PostScript plots - we can update those via DVC when the PR is accepted. |
I found a test that is also used separately in doc/scripts. I will remove that test and its baseline PS file. Do I run dvc add test/baseline/psxy to "remove" one file or is there a dvc remove command I should use instead. First time I remove a test... |
You can try:
|
Hi @GenericMappingTools/gmt-contributors-
The documentation for plot got much better after adding the illustrations of the many type of symbol groups. However, there are many other modules that could benefit from either
A representative figure just below the
Description
sectionAn illustrative figure at the end of the stuff for some option -X
Some may need both. This requires familiarity with GMT and ability and willingness to write a short script that makes the figure, or search through test/module to see if we already have one among the tests. If you have suggestions for such and willing to do it, open a PR with a title like "WIP supporting figure for module xxxxxx" where your branch off master simply adds the script with a useful name like the others in doc/script, e.g. GMT_segmentations.sh. Select the core collaborator team for the review. The team can then try it out. Just post the figure on GItHub for now (do not add PS file to DVC etc since we need to review first).
Ideally, the illustration is made at 15cm by 5 cm unless by nature it needs to be taller or square.
The text was updated successfully, but these errors were encountered: