-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: List the PyGMT talk at AGU24 in the "Overview" section | Keep large thumbnail images for "Overview" section ? #3685
base: main
Are you sure you want to change the base?
Conversation
/format |
Two notes:
|
Hm. I also was a bit wondering about the sizes of the image files. But when comparing the image added newly in the PR with the already included images, the file size is in the same range: I reduced the size of my image via the tool @seisman mentioned and now it is 140 KB large. |
Yes, adding the conference contributions to the “overview” section is not directly intuitive. But maybe the idea of adding these materials to the overview page was to show how the PyGMT project developed over time (instead of any kind of history section). Some of these contributions are more an overview of the main ideas and aims of the project rather than a more detailed presentation on PyGMT. |
These large images were added at the very early stage of the project and I think that's not a good practice. |
Then we probably have to discuss / decide if we want to keep / continue the list of conference contributions as is or remove these images from the repo. Or we find a solution where we can just link to an image which serves as thumbnail image. |
Description of proposed changes
List the PyGMT talk at AGU24 in the "Overview" section
Preview: https://pygmt-dev--3685.org.readthedocs.build/en/3685/overview.html
Fixes: #3683 (partly)
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash command is:
/format
: automatically format and lint the code