Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix]: At deployment, exclude source code files that are not used #481

Open
andreia-oca opened this issue Oct 23, 2023 · 2 comments
Open
Labels
contributions New improvement task good first issue Good for newcomers

Comments

@andreia-oca
Copy link
Member

andreia-oca commented Oct 23, 2023

Describe your task

This task is a bug fix.

Steps to reproduce the bug:

  1. Clone any genezio example - e.g. the typescript getting started example[1].
  2. Create a new .ts file on the server side and write something that generates a typescript error in it - for example:
export class TaskService {
    constructor() {
        this.fail(); // this method is not declared, so it will fail
    }
}
  1. Run genezio deploy.
  2. The process will fail:
Bundling your code...
|  [2023-10-23T14:36:33.672Z] DEBUG: The bundling process has started for file ./task.ts...
[2023-10-23T14:36:33.947Z] DEBUG: Typechecking Typescript files...
bug.ts(3,14): error TS2339: Property 'fail' does not exist on type 'TaskService'.

Typescript compilation failed.

This is not the expected behavior.

The deployment process should successfully end because the newly created file/class is not included in the genezio.yaml, hence it shouldn't be part of the deployment bundle.

[1] https://github.com/Genez-io/genezio-examples/tree/main/typescript/getting-started

@andreia-oca andreia-oca added contributions New improvement task good first issue Good for newcomers labels Oct 23, 2023
@andreia-oca andreia-oca changed the title [Bug fix task]: At deployment, exclude source code files that are not used [Bug fix]: At deployment, exclude source code files that are not used Oct 23, 2023
@bhavyastar
Copy link

I would also like to work on this issue @andreia-oca .

@andreia-oca
Copy link
Member Author

That's great, feel free to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions New improvement task good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants