Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't upgrade Genie without downgrading Memento, slowing down PostgreSQL driver loading #269

Closed
PallHaraldsson opened this issue Aug 19, 2020 · 3 comments
Assignees

Comments

@PallHaraldsson
Copy link
Contributor

[I was debugging slow loading of LibPQ.jl, I think you use, or at least your users, and I got its loading speed from 10 to 8.6 sec., actually Memento was a slow dependency and together we got it down to 1.6 sec. with v1.1.1.]

I couldn't install latest Memento to test until I removed a bunch of packages, and finally yours, and then predically I can't add it back:

(@v1.6) pkg> add --preserve=all Genie#master
   Updating git-repo `https://github.com/GenieFramework/Genie.jl.git`
  Resolving package versions...
ERROR: Unsatisfiable requirements detected for package FilePathsBase [48062228]:
 FilePathsBase [48062228] log:
 ├─possible versions are: [0.2.0, 0.3.0-0.3.1, 0.4.0, 0.5.0, 0.6.0-0.6.2, 0.7.0, 0.8.0, 0.9.0-0.9.4] or uninstalled
 ├─restricted to versions 0.9.4 by an explicit requirement, leaving only versions 0.9.4
 └─restricted by compatibility requirements with FilePaths [8fc22ac5] to versions: 0.6.0-0.6.2 — no versions left
   └─FilePaths [8fc22ac5] log:
     ├─possible versions are: [0.7.0, 0.8.0] or uninstalled
     └─restricted to versions 0.8 by Genie [c43c736e], leaving only versions 0.8.0
       └─Genie [c43c736e] log:
         ├─possible versions are: 1.1.0 or uninstalled
         └─Genie [c43c736e] is fixed to version 1.1.0

I'm a bit new to all this, so I haven't fully tracked down:

(@v1.6) pkg> add Genie#master
   Updating git-repo `https://github.com/GenieFramework/Genie.jl.git`
  Resolving package versions...
Updating `~/.julia/environments/v1.6/Project.toml`
  [c43c736e] + Genie v1.1.0 `https://github.com/GenieFramework/Genie.jl.git#master`
  [9da8a3cd] ↓ JLSO v2.3.3 ⇒ v2.1.0
  [f28f55f0] ↓ Memento v1.1.1 ⇒ v0.12.1
Updating `~/.julia/environments/v1.6/Manifest.toml`
  [8fc22ac5] + FilePaths v0.8.0
  [48062228] ↓ FilePathsBase v0.9.4 ⇒ v0.6.2
  [c43c736e] + Genie v1.1.0 `https://github.com/GenieFramework/Genie.jl.git#master`
  [9da8a3cd] ↓ JLSO v2.3.3 ⇒ v2.1.0
  [f28f55f0] ↓ Memento v1.1.1 ⇒ v0.12.1
  [39ec1447] + Millboard v0.2.5
  [49dea1ee] + Nettle v0.5.0
  [4c82536e] + Nettle_jll v3.4.1+1
  [ddb6d928] + YAML v0.4.0
@essenciary
Copy link
Member

@PallHaraldsson I don't know what's causing this either. All of Genie's deps are on the latest allowed version, as far as I can tell:

(Genie) pkg> st
Project Genie v1.1.1
Status `C:\Users\adria\.julia\dev\Genie\Project.toml`
  [c7e460c6] ArgParse v1.1.0
  [8fc22ac5] FilePaths v0.8.0
  [708ec375] Gumbo v0.8.0
  [cd3eb016] HTTP v0.8.17
  [77172c1b] HttpCommon v0.5.0
  [682c06a0] JSON v0.21.0
  [e6f89c97] LoggingExtras v0.4.2
  [739be429] MbedTLS v1.0.2
  [39ec1447] Millboard v0.2.5
  [49dea1ee] Nettle v0.5.0
  [bac558e1] OrderedCollections v1.3.0
  [189a3867] Reexport v0.2.0
  [295af30f] Revise v2.7.3
  [30578b45] URIParser v0.4.1
  [ddb6d928] YAML v0.4.0
  [ade2ca70] Dates
  [8ba89e20] Distributed
  [56ddb016] Logging
  [d6f4376e] Markdown
  [44cfe95a] Pkg
  [3fa0cd96] REPL
  [ea8e919c] SHA
  [9e88b42a] Serialization
  [6462fe0b] Sockets
  [4ec0a83e] Unicode

(Genie) pkg> resolve
   Updating `C:\Users\adria\.julia\dev\Genie\Project.toml`
 [no changes]
   Updating `C:\Users\adria\.julia\dev\Genie\Manifest.toml`
 [no changes]

(Genie) pkg> up
   Updating registry at `C:\Users\adria\.julia\registries\General`
   Updating git-repo `https://github.com/JuliaRegistries/General.git`
   Updating `C:\Users\adria\.julia\dev\Genie\Project.toml`
 [no changes]
   Updating `C:\Users\adria\.julia\dev\Genie\Manifest.toml`
 [no changes]

@essenciary
Copy link
Member

From the looks at your output maybe related to FilePaths and FilePathsBase - checking.

@essenciary
Copy link
Member

OK, found it - latest registered FilePaths is v0.8 (used by Genie) and restricts FilePathsBase to v0.6. The lower version of FilePathsBase triggers downgrades in JSLO and Memento which depend on FilePathsBase. FilePaths v0.8.1 should be registered as that upgrades FilePathsBase.

https://github.com/rofinn/FilePaths.jl/blob/c3da500b4f83d38d7927b83604bfeb92255a8a0f/Project.toml
rofinn/FilePaths.jl@c3da500#diff-910a7b3ca0075d545dcec45cb7335ca9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants