Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make websocket diconnection alert more flexible and automatically clear upon reconnection #722

Open
hhaensel opened this issue Nov 6, 2024 · 0 comments

Comments

@hhaensel
Copy link
Member

hhaensel commented Nov 6, 2024

Is your feature request related to a problem? Please describe.
Currently, the ws connection alert is handled by adding an anchored div to the end of the document and setting the site's location to the anchor. This spills the url, moves the focus of the page and it doesn't disappear upon reconnecting.

Describe the solution you'd like

  • make the warning an overlay
  • prepend an equally spaced div to the page to avoid blocking functionality of the UI, which might also work without ws
  • let the user chose whether to display the above div
  • let the user chose whether to display the alert
  • clear the overlay upon reconnection, don't display the alert, if the reconnection was done within the webchannels_server_gone_alert_timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant