Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add timer "seconds lapsed" #154

Closed
BilelJegham opened this issue Apr 10, 2021 · 5 comments · Fixed by #156
Closed

[FEAT] Add timer "seconds lapsed" #154

BilelJegham opened this issue Apr 10, 2021 · 5 comments · Fixed by #156
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@BilelJegham
Copy link
Member

BilelJegham commented Apr 10, 2021

Is your feature request related to a problem? Please describe.
Add timer "seconds lapsed" per round and sum per game

Describe the solution you'd like

  1. Add in-game interface
  2. Add in history game detail

Link to #152

@BilelJegham BilelJegham added the enhancement New feature or request label Apr 10, 2021
@BilelJegham
Copy link
Member Author

Step2:
Include "total seconds lapsed" in New score mode

@BilelJegham BilelJegham added this to the 0.6.0 milestone Apr 10, 2021
@BilelJegham BilelJegham self-assigned this Apr 12, 2021
@BilelJegham BilelJegham linked a pull request Apr 13, 2021 that will close this issue
@BilelJegham
Copy link
Member Author

Hi @tululum
Step 1 and step 2 ready in #156

Can you give me feedback ?
https://deploy-preview-156--geoguess2.netlify.app/

You can select score mode "Time" .
image

@tululum
Copy link
Contributor

tululum commented Apr 14, 2021

Wow, that was fast. :O But no timer shows up for me at all. :/
https://youtu.be/QLJZVnh5xGA

@BilelJegham
Copy link
Member Author

I only add it at the end of the game in History Page.
image

Add it in the Header can be great 👍

@tululum
Copy link
Contributor

tululum commented Apr 15, 2021

Ohh, ok :) Yeah, adding it to the header and possibly even to the round results would be super cool :) :

image

Also a small bug: after a 2-player game, the time for every round is shown as Not a Number:
image

Otherwise looks good :)

If I may propose, it would be super awesome to make this cooperative mode now before doing the group versus play (step 3). For cooperative play all players would spawn and move as normal, but only one single guess could be made for the whole group (once anyone makes a guess, the round ends for everyone). Also, the score would be a single score shared with all players in the game. So when playing with friends you can move around independently, but all guessing and scoring is shared with all players - so basically they play as a group, together, talking about where they think they are, what they see, discussing options and then making a one single best guess they all agree to, receive score together (since everyone collaborated on the guess) and move to the next round.

I think this cooperative play (well, basically group scoring) shouldn't hopefully be as difficult to do as 3vs3 for example, because it only consists of two (seemingly small) changes:

  1. A one single guess is made for the whole group - when the guess is made by any player, the round ends for everyone (this functionality is already implemented in Pick a country TimeAttack mode, so hopefully can be reused with only minor changes)
  2. All players share a common score.

Let me know what you think ;) Anyway, thanks, its looking good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants