Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firebase url env #68

Closed
AlexSpelt opened this issue Dec 13, 2020 · 3 comments · Fixed by #69
Closed

Firebase url env #68

AlexSpelt opened this issue Dec 13, 2020 · 3 comments · Fixed by #69
Assignees
@BilelJegham

Comments

@AlexSpelt
Copy link

Google Firebase has an option to use a server in west Europe for me. But I think the firebase URL changes because of that option.

Right now Geoguess uses https://.firebaseio.com. I had to use https://-default-rtdb.europe-west1.firebasedatabase.app.

I solved this issue by changing the code from my forked version in src/main.js.

I suggest adding a separate env variable for URLs.
@BilelJegham BilelJegham self-assigned this Dec 17, 2020
@BilelJegham BilelJegham linked a pull request Dec 17, 2020 that will close this issue
Fixs #67 Streetview search radius + #68 Firebase config #69
Merged
BilelJegham pushed a commit that referenced this issue Dec 17, 2020
fix: #68 add firebase env var url
1763ab7
@BilelJegham BilelJegham mentioned this issue Dec 17, 2020
Merged
@BilelJegham
Copy link
Member

BilelJegham commented Dec 17, 2020 •
edited
Loading

Thanks for the report. I didn't know.

I had 3 env variables : VUE_APP_FIREBASE_AUTH_DOMAIN, VUE_APP_FIREBASE_DATABASE_URL, VUE_APP_STORAGE_BUCKET

The pull request will merge soon :)

@BilelJegham
Copy link
Member

@all-contributors please add @AlexSpelt for bug

@allcontributors allcontributors bot mentioned this issue Dec 17, 2020
Merged
@allcontributors
Copy link
Contributor

@BilelJegham

I've put up a pull request to add @AlexSpelt! 🎉

BilelJegham added a commit that referenced this issue Dec 20, 2020
@BilelJegham
Merge pull request #69 from GeoGuess/feature/67-bugpolygonGeojson
d4c7da2 
Fixs #67 Streetview search radius + #68 Firebase config
@BilelJegham BilelJegham mentioned this issue Mar 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BilelJegham BilelJegham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixs #67 Streetview search radius + #68 Firebase config GeoGuess/GeoGuess
2 participants
@BilelJegham @AlexSpelt