Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Are you sure to leave this window?" should be implemented? #95

Closed
wlanowski opened this issue Jan 30, 2021 · 6 comments · Fixed by #107
Closed

"Are you sure to leave this window?" should be implemented? #95

wlanowski opened this issue Jan 30, 2021 · 6 comments · Fixed by #107
Assignees
Labels
enhancement New feature or request

Comments

@wlanowski
Copy link
Contributor

Hi there!

It is a big problem, especially on mobile devices, that reloading the page, or "going back" in the browser destroys the game for all players. Maybe it is possible to implement this "Are you sure to leave this page" allert via JS as a first step. (Would be this okay with PWA requirements? Idk). Maybe later it would be nice, if it is possible to reenter to the room and leaving without destroying the game.

@BilelJegham
Copy link
Member

BilelJegham commented Jan 31, 2021

I answer in discord. I don't see PR to that yet. 😢

Ask him maybe he will make a PR.

https://discord.com/channels/758443244387303435/758976664050335764/796800342717235201

@BilelJegham BilelJegham added the enhancement New feature or request label Jan 31, 2021
@BilelJegham
Copy link
Member

BilelJegham commented Jan 31, 2021

Maybe later it would be nice, if it is possible to reenter to the room and leaving without destroying the game.

For this, maybe one day. I know how it can be frustrating when player leave the game.

@wlanowski
Copy link
Contributor Author

I want to highlight this issue because it is a big problem within my playing community...

It would be nice if this alert appears. We should prove whether this alert is compatible with PWA, we should not destroy our PWA-functionality with this...

@BilelJegham
Copy link
Member

Did you ask on discord FunnyPocketBook to make an pr ? @wlanowski https://discord.com/channels/758443244387303435/758976664050335764/796800342717235201

@BilelJegham BilelJegham self-assigned this Feb 20, 2021
BilelJegham added a commit that referenced this issue Feb 21, 2021
@BilelJegham BilelJegham linked a pull request Feb 21, 2021 that will close this issue
@BilelJegham
Copy link
Member

@wlanowski Made, can you check on https://deploy-preview-107--geoguess2.netlify.app/ ?
😉

@wlanowski
Copy link
Contributor Author

Looks good! Checked on desktop, mobile (firefox and chrome) and pwa (firefox and chrome).

If possible, add the possibility to translate "Are you sure to leave the current game" via crowdin.

Thanks a lot!

BilelJegham added a commit that referenced this issue Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants