Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: countdown #106 #123

Merged
merged 4 commits into from
Mar 7, 2021
Merged

feature: countdown #106 #123

merged 4 commits into from
Mar 7, 2021

Conversation

BilelJegham
Copy link
Member

closes #106

@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #123 (b31ba32) into master (e5ea43e) will increase coverage by 4.12%.
The diff coverage is 57.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
+ Coverage   27.82%   31.94%   +4.12%     
==========================================
  Files          31       31              
  Lines         974      986      +12     
  Branches      174      180       +6     
==========================================
+ Hits          271      315      +44     
+ Misses        699      667      -32     
  Partials        4        4              
Impacted Files Coverage Δ
src/components/Maps.vue 5.88% <0.00%> (+5.88%) ⬆️
...rc/components/dialogroom/card/CardRoomSettings.vue 7.69% <ø> (ø)
src/pages/StreetView.vue 12.98% <71.42%> (+12.98%) ⬆️
src/components/dialogroom/DialogRoom.vue 22.31% <100.00%> (+0.64%) ⬆️
src/components/DialogSummary.vue 5.26% <0.00%> (+5.26%) ⬆️
src/mixins/ConfirmExitMixin.js 26.66% <0.00%> (+26.66%) ⬆️
src/components/HeaderGame.vue 33.33% <0.00%> (+33.33%) ⬆️
src/components/game/DetailsMap.vue 33.33% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5ea43e...b31ba32. Read the comment docs.

@wlanowski
Copy link
Contributor

Is it ready to beta test or to merge? 😀

@BilelJegham
Copy link
Member Author

Beta test finish but units tests were not implemented (reason of codecov checks fails)

I will try to write them this weekend.

@BilelJegham BilelJegham merged commit dc36c68 into master Mar 7, 2021
@BilelJegham BilelJegham deleted the feature/106-coutdown branch March 7, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] countdown after 1st guess
2 participants