Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature to enable Photo Spheres #78

Merged
merged 12 commits into from
Mar 21, 2021

Conversation

maksovnik
Copy link
Contributor

DEFAULT is ON, resets when pressing Play Again

@netlify
Copy link

netlify bot commented Jan 10, 2021

Deploy request for geoguess2 accepted.

Accepted with commit 1855f95

https://app.netlify.com/sites/geoguess2/deploys/6055feda745bda0007407826

@BilelJegham BilelJegham changed the base branch from feature/select-country to master January 12, 2021 17:21
Copy link
Member

@BilelJegham BilelJegham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a good start in JS and VueJs 😃
I report a few feedback to fix before merge

CHANGELOG.md Outdated Show resolved Hide resolved
src/components/Maps.vue Outdated Show resolved Hide resolved
src/components/widgets/card/CardRoomSettings.vue Outdated Show resolved Hide resolved
src/lang/TranslationsEN.js Outdated Show resolved Hide resolved
src/pages/StreetView.vue Outdated Show resolved Hide resolved
src/components/widgets/card/CardRoomSettings.vue Outdated Show resolved Hide resolved
@BilelJegham
Copy link
Member

It seems, you need to change unit test : tests/unit/components/dialogRoom/DialogRoom.spec.js
image

@codecov
Copy link

codecov bot commented Mar 20, 2021

Codecov Report

Merging #78 (cc0d5b9) into master (0752bbd) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   34.36%   34.36%   -0.01%     
==========================================
  Files          31       31              
  Lines        1001     1004       +3     
  Branches      185      187       +2     
==========================================
+ Hits          344      345       +1     
- Misses        653      655       +2     
  Partials        4        4              
Impacted Files Coverage Δ
...rc/components/dialogroom/card/CardRoomSettings.vue 7.69% <ø> (ø)
src/pages/StreetView.vue 15.66% <0.00%> (-0.15%) ⬇️
src/components/dialogroom/DialogRoom.vue 22.95% <100.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0752bbd...cc0d5b9. Read the comment docs.

@maksovnik maksovnik requested a review from BilelJegham March 20, 2021 14:04
@BilelJegham BilelJegham merged commit 14dd468 into GeoGuess:master Mar 21, 2021
@BilelJegham
Copy link
Member

@all-contributors please add @maksovnik for code

@allcontributors
Copy link
Contributor

@BilelJegham

I've put up a pull request to add @maksovnik! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants