Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyCSW3 upgrade #12535

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

PyCSW3 upgrade #12535

wants to merge 15 commits into from

Conversation

Gpetrak
Copy link
Contributor

@Gpetrak Gpetrak commented Aug 29, 2024

PyCSW3 upgrade on GeoNode. Related issue

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

Copy link

cla-bot bot commented Aug 29, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Gpetrak on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

Copy link

cla-bot bot commented Aug 29, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Gpetrak on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@mattiagiupponi mattiagiupponi marked this pull request as draft August 30, 2024 08:32
@mattiagiupponi mattiagiupponi linked an issue Aug 30, 2024 that may be closed by this pull request
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.26%. Comparing base (c1545ff) to head (f756bce).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12535   +/-   ##
=======================================
  Coverage   64.26%   64.26%           
=======================================
  Files         888      888           
  Lines       53610    53610           
  Branches     6606     6606           
=======================================
+ Hits        34451    34453    +2     
+ Misses      17650    17648    -2     
  Partials     1509     1509           

@giohappy giohappy requested a review from etj September 2, 2024 07:50
@Gpetrak Gpetrak marked this pull request as ready for review September 2, 2024 07:52
@giohappy giohappy added this to the 5.0.0 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to PyCSW 3
2 participants