-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed basemap for thumbnails to wikimedia, fixes #4459 #4509
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4509 +/- ##
=======================================
Coverage 59.48% 59.48%
=======================================
Files 230 230
Lines 12111 12111
Branches 1750 1750
=======================================
Hits 7204 7204
Misses 4323 4323
Partials 584 584 |
Travis fails due to Not related to the pr |
Nice! |
@frafra yes, but notice this will only change the tiles used for thumbnails. The basemap in mapstore/geoexplorer will stay the same. |
checks had passed succesful: triggered a merge with global master .. |
Right. I think we should have attribution on all these previews, as we are violating https://www.openstreetmap.org/copyright (which has to be followed for Wikipedia maps too). A different issue+PR maybe? :-D |
I am discussing with the Italian OSM community about that. Someone says that we could skip attribution on the preview, but only if that is a preview: if we use Wikipedia maps for the thumbnail and OSM maps for the data, I guess we will have to credit Wikipedia. We can switch entirely to Wikipedia or attribute Wikipedia on the thumbnails I guess. |
@frafra any chance to have confirmation that the previews do not need attribution? I don't think so as they are static snapshots, but I'm not sure. We should probably add some disclaimers at the bottom of the portal or somewhere on some dedicated page. This is probably part of a new PR as it requires some additional work and decisions. |
@afabiani cannot confirm, but they should not. I would say that we can approve this PR, as the licensing is exactly the same as OSM tiles and do another one when we are certain about how to behave in this kind of situation. |
This PR will change the default thumbnail basemap to wikimedia. This will result in some legal constraints, eg:
You License Freely Your Contributions – you generally must license your contributions and edits to our sites or Projects under a free and open license (unless your contribution is in the public domain).
The full Terms of Use is listed here: https://foundation.wikimedia.org/wiki/Terms_of_Use/en
It fixes openstreet map tileserver responding with a 404 for the thumbnail creation requests as mentioned in #4459 .
Additionally the wikimedia thumbnails have a much better resolution which results in nicer thumbnails for intermediate sized devices (bootstrap md)
BEFORE MERGING: Please read the full terms of usage