Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose button in direct messages #619

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

henryrov
Copy link
Contributor

This is a draft implementation of the feature requested by #612. Some considerations:

  • I'm not sure if adding another action is the most desirable way to achieve this, but it plays nicely with the existing codebase
  • What button icon to use
  • Not specifically related to this issue, but maybe add a scroll-to-top button to the messages tab in the future
    Of course, if this feature isn't thought to be necessary or make sense within Tuba at the moment, feel free to close this.

@GeopJr
Copy link
Owner

GeopJr commented Oct 24, 2023

Thanks for this PR!

From a quick look the main concern is the floating button. It's a bit more complex than that:

  • It has to play nice with the scroll to top button (on Home, the scroll to top button moves above it)
  • On narrow mode (/ mobile), it has to disappear when scrolling down and re-appear when scrolling up, but not instantly, you have to scroll up a bit more (following android's behavior)
  • On narrow mode it has to be visible when near the top
  • It needs to be inside a revealer so there's an animation when it (dis)appears
  • There needs to be an animation when the scroll to top button is also visible ([Request]: Compose button: reduce animation wonkiness, improve discoverability #548 (comment))

Depending on how the discussion on #612 goes, ideally, the code from the Home view should move either to the Timeline view (visible in all timelines) or to a new FloatingButtonView so both Home and Conversations can inherit from it instead of having to duplicate the same complex logic for each one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants