Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(emoji): libsoup cache lookup #915

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Conversation

GeopJr
Copy link
Owner

@GeopJr GeopJr commented Apr 20, 2024

Suggested by Fabian on matrix, instead of going through libsoup's cache process, let's look it up ourselves.

Why? Because libsoup does complex cache checking that also needs to be decoded:

  • Libsoup will respect etag, max cache and other headers
  • Whether it hits cache or not, it still needs to go through all the process of getting decoded, orientation fixed etc

Compared to just, checking if the file exists already and loading it.

Libsoup's cache is important, especially on profile avatars and API responses. It's not that much on emojis and in situations where it has to load thousands at the same time (CEP), this seems faster

Quirk: libsoup maps images to cache entries using g_str_hash based on the url

@GeopJr GeopJr merged commit 486cb23 into main Jun 14, 2024
5 checks passed
@GeopJr GeopJr deleted the feat/emoji/soup-cache-lookup branch June 14, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant