Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Username type configurable #104

Closed
Wissididom opened this issue May 8, 2023 · 4 comments · Fixed by #144
Closed

Make Username type configurable #104

Wissididom opened this issue May 8, 2023 · 4 comments · Fixed by #144
Labels
enhancement New feature or request

Comments

@Wissididom
Copy link
Collaborator

Wissididom commented May 8, 2023

This is basically just a reminder issue to:

  • Make sure we only use IDs in the Code during the migration. During the migration Usernames will have a descriminator of value 0 returned (e. g. wissididom#0)
  • Also Bot names and icons will be unified so there is just one for each application (currently you have one for the app and one for the bot), so the README.md's (at least) screenshots need to be updated. Also each application automatically gets assigned a bot.

Resources:
Discord Help Center Article
Discord Developer Help Center Article

@Wissididom
Copy link
Collaborator Author

Probably waiting on the following two PRs to be merged and released before we are able to adjust the code to respect that change:
discordjs/discord.js#9634
discordjs/discord.js#9631

As Discord does not break things yet because we are saving things as IDs (thankfully we changed that in the replit version already) and they are simply returning the pomelo name as username (lowercase, only latin characters and dots and underscores) and 0 as discriminator (the 4 digits after the # of a discord name). The update of discord.js would just help us use the Global Display Name instead of the unique pomelo username.

@Wissididom
Copy link
Collaborator Author

What should be the prefered name to show when we change it? There is three names that will be available: Username, Display Name and Nickname (where the nickname is per server/guild).

  1. Nickname if exists -> Display Name if exists -> Username in any other case
  2. Nickname if exists -> Username in any other case
  3. Display Name if exists -> Username in any other case
  4. Display Name if exists -> Nickname if exists -> Username in any other case
  5. Always Username (how it currently is)
  6. Make it configurable in the admin settings. But then we would still need a default. Maybe with a command like /settings name format:<predefined choices list to choose from>.

The only name that is unique is the Username, there can be multiple people with the same Display Name and the same Nickname.

My preference would be 6 with a default value of 5 so in the default settings there cannot be any impersonation or trolling with display names and nicknames.

@Wissididom Wissididom added the enhancement New feature or request label Jul 28, 2023
@Wissididom Wissididom changed the title Reminder Issue: Make sure the migration to usernames keeps working Check if we need to change how usernames are sent in Discord Jul 28, 2023
@GeorgeCiesinski
Copy link
Owner

This is a very good point. I was going to go with 6 with a default of 1, but I think your concern is valid and we should go with 6/5 instead. The server admins can configure it the way they want that way.

@Wissididom Wissididom linked a pull request Jan 1, 2024 that will close this issue
@Wissididom Wissididom changed the title Check if we need to change how usernames are sent in Discord Make Username type configurable Jan 2, 2024
@Wissididom
Copy link
Collaborator Author

Resolved in #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants