Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better way to handle external files #11

Open
seanmacavaney opened this issue May 6, 2020 · 0 comments
Open

Better way to handle external files #11

seanmacavaney opened this issue May 6, 2020 · 0 comments

Comments

@seanmacavaney
Copy link
Contributor

Introduced in #8 - found that dependent file from MS-MARCO has gone missing mysteriously (https://msmarco.blob.core.windows.net/msmarcoranking/qidpidtriples.train.full.tar.gz). Contacted dataset owners but got no response, so self-hosting for now.

Really shows how fragile the system could be if required files disappear like this. Perhaps it's good to mirror all files (at least, files that there's no licensing restriction for hosting elsewhere) some other place, and have some method for falling back onto the mirrors if they go missing. I know this has been an issue for TREC in the past with govt shutdowns. This is all the more reason to include hashes for all the files.

Maybe introduce a new class to manage this. Something that could operate like:

dl = util.Downloadable("http://location/1", "http://mirror/1", "http://mirror/2", expected_md5="...")
for line in dl.download_stream():
    ...

Some download operations (like saving files directly or as tmp files) would work with this paradigm. But how could we handle switching to mirrored version of streamed content if hash doesn't match at end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant