-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with PS2 cover thumbnail #384
Comments
That's odd and I'm not sure what would cause it. (Non-rectangular thumbnail maybe?) Does it still happen if you clear the system thumbnail cache using rp-config? |
If I clean the system cache, the thumbnail draws correctly, that's actually what caused me to think its a race condition or some other slightly weird edge case. I know that Windows has some weird issues with non-standard thumbnail proportions, so you might be onto something. I will generate thumbnails for the rest of the games in the library to stress it and see if I notice anything else. I would test ps1 as well but those are all in chd because I detest dealing with bin/cue lol |
Unfortunately I probably can't do much about that in that case. Only thing I can think of is maybe rom-properties is returning the full-size image instead of shrinking it first, which might cause problems. Will take a look and see if shrinking is necessary. |
I don't know if its the increased latency of a network connection causing things to not line up just wrong enough to cause issues or what, but I haven't been able to generate any more bugged thumbnails from my archive. Local ones still do though |
@GerbilSoft Is there anywhere to get beta's or nightlies? I know you have the appveyor, but last I checked, artifact retention was either off or not working because no jobs seem to ever have any |
That's odd, I thought I had configured artifacts. Will fix that later today. Note that AppVeyor does separate per-architecture builds, so you'll need to download both the 32-bit and 64-bit versions separately. (Or just the 64-bit version if you don't use any 32-bit software.) |
Wanted to let you know, so far I have ran into a issue where a couple thumbnails looked like it was swizzled and a couple others have corruption in most of the image. I forgot to take a pic of the swizzled ones but I have a pic of the other one.
Looking at the backing image from the repo and the properties sheet in Windows, the images are fine, so maybe some sort of race condition between rom-properties supplying the image and Windows trying to display the thumbnail?
The text was updated successfully, but these errors were encountered: