Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with the Symbols View in Atom #279

Closed
johnbillion opened this issue Feb 28, 2017 · 6 comments
Closed

Integration with the Symbols View in Atom #279

johnbillion opened this issue Feb 28, 2017 · 6 comments

Comments

@johnbillion
Copy link

Jumping to any symbol in the project doesn't appear to be possible currently because the package doesn't use ctags and therefore doesn't populate the project symbols list (Symbols View: Toggle Project Symbols).

Would it be possible to use PHP Integrator's list of project symbols to populate this list so it's possible to quickly jump to any symbol in the project?

@Gert-dev
Copy link
Owner

Gert-dev commented Mar 2, 2017

It may be, I'll have to investigate this further to see if I can link suggestions from the core to Atom's symbol search package. It depends on whether this package exposes a service that I can hook into with my own suggestions, which will then replace the default ctags suggestions (which don't always seem to work that well).

@tillkruss
Copy link

I'd love to see that as well.

@Gert-dev: Are you already working on this, or looking for contributions?

@Gert-dev
Copy link
Owner

Gert-dev commented May 27, 2017

@tillkruss It is not something I'm working on at the moment, but functionality I am interested in having (along with tons of other features and enhancements you'll find scattered across all the issues on the core and package repositories that I all want to have and write, if only I had infinite time 😄).

I've taken a quick gander at symbols-view from Atom, but it unfortunately does not seem to expose a service, it only supports TAGS files. I guess it would be possible to generate these files with data from the core, but it feels as if there should be a more generic way of providing symbols to Atom. Perhaps there already is a generic package, like autocomplete-plus, tester, ... that does this, that I'm not yet aware of.

In case anyone is looking to implement this (or any new feature like this), I'd be happy to provide guidelines on how to do it. In any case, it'd be most interesting to add this functionality to the core (i.e. implement it in PHP) and then just provide a list of the symbols back to the base package in Atom. Atom could then handle showing the suggestions in a fuzzy finder dialog (or send the requests to a symbol viewer package via a service, if one exists or is created).

@tillkruss
Copy link

atom/symbols-view#204

@Gert-dev
Copy link
Owner

Gert-dev commented Jan 27, 2018

FYI, I've created this ticket in the core to track progress on it. Also, this no longer has to wait for symbols-view, as atom-ide-ui now has an LSP-compliant way to do this.

@Gert-dev
Copy link
Owner

Gert-dev commented Jul 7, 2018

It's coming 🎉

outline

... well, "it" is not really correct, as this ticket was originally about the Atom symbols-view package. What is coming is support for atom-ide-ui's outline view, which is also based on symbols.

I'm still going to close this issue since, despite the efforts of @tillkruss, the symbols-view package still doesn't have a service, so there is nothing we can do currently to integrate with it.

If they do provide one in the future, I'd be interested in adding it, but the way things are going now, I suspect we'd have more chance of atom-ide-ui adding a shortcut to jump to the filter input field on the outline view than symbols-view adding a service.

@Gert-dev Gert-dev closed this as completed Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants