Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide relevant ricardian contract for actions #83

Closed
friedger opened this issue Jun 10, 2018 · 4 comments
Closed

Provide relevant ricardian contract for actions #83

friedger opened this issue Jun 10, 2018 · 4 comments
Labels
enhancement New feature or request Important

Comments

@friedger
Copy link

As stated in the constitution, a ricardian contract shall come with each contract.
It would be good to have at least a link to that document.

See
https://github.com/EOS-Mainnet/governance/blob/master/eosio.system/eosio.system-clause-constitution-rc.md#article-vii---open-source

@nsjames nsjames added enhancement New feature or request Important labels Jun 13, 2018
@nsjames
Copy link
Contributor

nsjames commented Jun 13, 2018

It's possible these could have their own tab inside of the "Signature Request" popup. Let me see how we can even do this as it will also require a parser since the {{ x }} within the ricardian contracts don't actually validate to javascript bindings.

@nsjames
Copy link
Contributor

nsjames commented Jun 19, 2018

Ricardian contracts are now supported per action but not for the constitution yet.
cb63016

Constitution will be displayed every time a user imports a new EOS account into Scatter.

This is not yet built into the zip because fetching ricardian contracts add significant overhead ( 2 - 6 seconds ) to the user-experience every time a signature request is issued, depending on individual contract ABI size.

I've added a ticket on the eosjs repo about a way to solve this here: EOSIO/eosjs#206

@abourget
Copy link

When are we going to see ricardian contracts?

@nsjames
Copy link
Contributor

nsjames commented Dec 4, 2019

@abourget Ricardians were removed from Scatter due to security concerns.
With the way that they are currently written, there's no safe way to parse them.

@nsjames nsjames closed this as completed Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Important
Projects
None yet
Development

No branches or pull requests

3 participants