Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Allow for custom mentions trigger controller to be plugged to StatusUpdateForm #338

Closed
MartinCupela opened this issue Mar 3, 2022 · 0 comments · Fixed by #342
Assignees
Labels
enhancement New feature or request

Comments

@MartinCupela
Copy link
Collaborator

MartinCupela commented Mar 3, 2022

Problem / Motivation

StatusUpdateForm accepts prop trigger that expects an object, which keys are strings serving as form's triggers for autocomplete feature. This feature is supported by a stale dependency react-textarea-autocomplete. The fact that the trigger has to be a string is limiting, because if user wants to define a more general trigger pattern in form of regex, this is not supported by the current dependency.

Proposed solution

Allow the user to provide own handler that would recognize regex triggers as well.

@MartinCupela MartinCupela self-assigned this Mar 3, 2022
@MartinCupela MartinCupela added enhancement New feature or request WIP Work in progress labels Mar 3, 2022
@MartinCupela MartinCupela changed the title Allow for custom mentions trigger controller to be plugged to StatusUpdateForm refactor: Allow for custom mentions trigger controller to be plugged to StatusUpdateForm Mar 7, 2022
@MartinCupela MartinCupela removed the WIP Work in progress label Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant