Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add options to truncate #81

Merged
merged 1 commit into from
Dec 7, 2021
Merged

feat: add options to truncate #81

merged 1 commit into from
Dec 7, 2021

Conversation

peterdeme
Copy link
Contributor

Adding options for truncating a channel.
Question: how can I make sure the truncation message was received in the channel? The channel message count is zero.

@ferhatelmas
Copy link
Contributor

Question: how can I make sure the truncation message was received in the channel?

  • Check the response message field
  • Query the channel separately to load its messages

@peterdeme peterdeme force-pushed the truncate-options branch 5 times, most recently from b7268b3 to e3e802b Compare December 7, 2021 14:59
@peterdeme peterdeme marked this pull request as ready for review December 7, 2021 15:12
@peterdeme
Copy link
Contributor Author

The message count is good now 👍

Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ferhatelmas ferhatelmas merged commit 71f4797 into master Dec 7, 2021
@ferhatelmas ferhatelmas deleted the truncate-options branch December 7, 2021 15:24
@github-actions github-actions bot mentioned this pull request Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants