Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make emoji-mart modular/optional #1715

Closed
3 tasks done
arnautov-anton opened this issue Aug 18, 2022 · 7 comments
Closed
3 tasks done

Make emoji-mart modular/optional #1715

arnautov-anton opened this issue Aug 18, 2022 · 7 comments
Assignees
Labels
cluster:emoji Issues related to use of emojis feature New capability

Comments

@arnautov-anton
Copy link
Contributor

arnautov-anton commented Aug 18, 2022

Motivation
Current implementation uses hardcoded emoji-mart features which makes it hard to upgrade and maintain and also unnecessarily increases SDK's package size.

Proposed solution
Remove from the SDK, make emoji-mart optional, introduce simpler API which could be used with different emoji pickers.

TODO:

@marcojacobsNL
Copy link

Is there any update on this? Because we're trying to upgrade to React 18 and NPM is always throwing errors related to this specific emoji-mart version not being compatible.

@arnautov-anton
Copy link
Contributor Author

Hey, @marcojacobsNL, we're currently working on resolving this issue. The plan is to release this fix by the end of this month if everything goes according to plan. We'll be releasing an alpha version with emoji-mart completely gone from the SDK sometime the week after next (16.10. - 20.10.). You should be able to move to React v18 without any major hiccups though, you might be greeted with warnigns but those should not affect the functionality of your application even with the current state of the SDK.

@arnautov-anton
Copy link
Contributor Author

Hey, everyone! Last week on Friday we released 11.0.0-rc.2 (on NPM) which now allows you to completely override (and remove) built-in EmojiPicker component and makes it slightly easier to implement your own emojiSearchIndex mechanism for our emoji autocomplete as it's no longer type-fixed to the one provided by the emoji-mart. We still need to decouple emoji-mart styling supplied with our CSS package to tackle issue #2116 - we'll be releasing that fix alongside with the update to our documentation in the RC3. We're still considering re-exporting some necessary emoji-mart parts for our default EmojiPicker component to make re-instating default behaviour slightly easier for our integrators, we'll be releasing that in RC4 for you to try out. I'll be updating this thread with new updates as we continue working on resolving this cluster of issues. We'll be grateful for any feedback/suggestions you'd have.

@arnautov-anton arnautov-anton self-assigned this Oct 30, 2023
@arnautov-anton
Copy link
Contributor Author

Another update for y'all - 11.0.0-rc.3 (on NPM) has been released with the major change to the styling bundles. Our custom emoji-mart styling and emoji-replacement (used in combination with Chat.useImageFlagEmojisOnWindows) styling are now distributed separately from the main CSS bundle making final bundle of the integrators who do not use these features slightly smaller. Again, we'll be grateful for any feedback/suggestions you'd have.

@cuvant
Copy link

cuvant commented Nov 24, 2023

Hi @arnautov-anton I've upgraded to 11.0.0-rc.3, and now the default emojis aren't showing anymore (theme V2). The "emoji-mart" package got updated to "^5.4.0", can't find any docs on how to get them back.

@arnautov-anton
Copy link
Contributor Author

Hey, @cuvant, we've mentioned release guides in our 11.0.0-rc.2 release which shipped with this change, here's the "reinstate previous behavior" segment in the release guide you're looking for. When installing release candidate versions make sure to install with @rc tag (yarn add stream-chat-react@rc) to get the latest version. Please follow the release notes across the RC releases - planned breaking changes are marked and come with transition guides. Once v11 is out, make sure to switch to the @latest distribution channel so you can keep taking advantage of patches and new features.

@arnautov-anton
Copy link
Contributor Author

arnautov-anton commented Nov 27, 2023

Hey, everyone! We've officially released 11.0.0 on the latest distribution channel. Features/fixes mentioned in this thread (and released in on our rc) have not changed much (if at all) so if you started transitioning earlier the switch to latest should be as easy as running yarn add stream-chat-react. Closing this issue with this comment, feel free to submit new-found issues related to our latest release. 🙂

See release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster:emoji Issues related to use of emojis feature New capability
Projects
None yet
Development

No branches or pull requests

4 participants