Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Beans AMP-compatible out-of-the-box. #246

Open
hellofromtonya opened this issue Jun 15, 2018 · 3 comments
Open

Make Beans AMP-compatible out-of-the-box. #246

hellofromtonya opened this issue Jun 15, 2018 · 3 comments

Comments

@hellofromtonya
Copy link
Contributor

Let’s make Beans AMP ready as part of the progressive theming initiatives. This change will require us to:

  1. integrate AMP tags into the HTML
  2. add the theme support add_theme_support( ‘amp’ );
  3. audit the compiled assets file sizes
@christophherr
Copy link
Member

christophherr commented Jun 21, 2018

Just listing a few examples of adding AMP support

https://github.com/Automattic/_s/pull/1286
https://github.com/xwp/wordpress-develop/pull/307
https://github.com/wprig/wprig/search?q=amp&unscoped_q=amp

@hellofromtonya
Copy link
Contributor Author

We'll have some work to do for integrating AMP tags into the HTML. Here are some examples of AMP-compatible themes:

Here are some talks on AMP by Alberto (Google) and @ThierryA:

Drum roll please...one of the leads to AMP and WordPress is our founder, @ThierryA! Cool!

@ibes
Copy link
Contributor

ibes commented Jun 22, 2018

I try to understand what AMP in the theme would mean.
Have not worked with AMP so far.

This looks interesting:
Pull request to make the standard themes AMP ready.
AMP for WordPress required the Plugin for WordPress, right?

xwp/wordpress-develop@3975dab

xwp/wordpress-develop@908bd69

What new requirements will the CSS, JS, HTML etc. will get through wanting to support AMP?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants