Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All In One WP Security plugin removes file permissions from screenshot.jpg and Beans updates fail #304

Closed
paaljoachim opened this issue Jul 17, 2018 · 8 comments · Fixed by #311
Assignees
Milestone

Comments

@paaljoachim
Copy link

paaljoachim commented Jul 17, 2018

I tried to update Beans 1.4 to 1.5 for a Norwegian culture house site that I run.

In the updates screen:

Notice the missing image thumbnail.

screen shot 2018-07-17 at 01 46 10

As it updates the Beans theme it goes through the steps and ends up with a failed update.
An error happened when Beans was updated: Update can not be installed because some of the files could not be copied. This is likely because of inconsequent file permissions. screenshot.jpg.

--

I turned off a few of the plugins to see if that would work but it did not.
I switched to Twenty Seventeen and then tried to update through the Appearance -> Theme tab and it showed me this:

screen shot 2018-07-17 at 02 00 26

Btw as I switched to another theme and then back again I lost one of the widgets in the footer area and had to reinsert it.
(Using this code: https://wpbeansframework.com/2018/05/31/how-to-add-3-widget-area-in-one-place/ )

If someone would like to take a look let me know and I will give you login information to the Norwegian site.

@hellofromtonya
Copy link
Contributor

Hello @paaljoachim, Hmm, I'm wondering if the host is blocking it. I just ran through an update on a couple of my sites to make sure the update service is working. And yes, it worked.

Have you had issues in the past with updating this client/site?

Another approach is to SFTP or SSH into the site to do the update that way.

@paaljoachim
Copy link
Author

paaljoachim commented Jul 17, 2018

I chatted with the host support and they fixed the permission error. They do not know why it happened.

Here is the message I received through Duplicator before the fix.

PHP is unable to read the following items and they will not be included in the package. Please work with your host to adjust the permissions or resolve the symbolic-link(s) shown in the lists below. If these items are not needed then this notice can be ignored.

/home/stabestr/public_html/wp-content/themes/tm-beans/screenshot.jpg

I will close this for now as I got this fixed.

@paaljoachim
Copy link
Author

paaljoachim commented Jul 17, 2018

I have now a dev site in place from before upgrading to Beans 1.5.
For whatever reason the screenshot had permission problems that the host reset.
Beans 1.5 also did something with the shortcodes I used from Eventon event plugin so that the front page did not show up as it should.

I can give login info to whomever who would like to take a look.

@paaljoachim paaljoachim reopened this Jul 17, 2018
@hellofromtonya
Copy link
Contributor

I've not been able to recreate this issue. Hey @christophherr, can you see if you can recreate it on your machine?

Beans 1.5 also did something with the shortcodes I used from Eventon event plugin so that the front page did not show up as it should.

@paaljoachim this would be a separate issue. Can you open a new one please?

@christophherr
Copy link
Member

I cannot recreate the issue.
@paaljoachim Any chance that permissions had been changed in the past?
Might have been for security reasons. ( I think in some "black market" themes and plugins, "image files" were used to disguise and spread malicious code...)

@paaljoachim
Copy link
Author

@christophherr I sent you a pm through slack with login info so that you can take a look.

@christophherr
Copy link
Member

The All In One WP Security plugin is removing the file permissions from screenshot.jpg and variations of that filename.

@hellofromtonya Is there a reason we are using a .jpg instead of the standard .png?

@christophherr christophherr changed the title Could not update to Beans 1.5 because of file permission error All In One WP Security plugin removes file permissions from screenshot.jpg and Beans updates fail Jul 22, 2018
@hellofromtonya hellofromtonya self-assigned this Jul 22, 2018
@hellofromtonya hellofromtonya added this to the 1.5.1 milestone Jul 22, 2018
@hellofromtonya
Copy link
Contributor

@christophherr PR #311 adds a newly designed screenshot that is in PNG format. This should close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants