Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: Audio control not visible on the frontend. #348

Open
paaljoachim opened this issue Nov 4, 2018 · 2 comments
Open

Gutenberg: Audio control not visible on the frontend. #348

paaljoachim opened this issue Nov 4, 2018 · 2 comments

Comments

@paaljoachim
Copy link

paaljoachim commented Nov 4, 2018

It is in relation to this issue at the Gutenberg repository:
WordPress/gutenberg#11447

I just tested Twenty Seventeen and notice the audio controls showing up there. It is not showing up in the Beans child theme I am using.

@christophherr
Copy link
Member

Looks like we need to add an explicit height to
audio
maybe something like

.wp-block-audio audio {
     height: 50px;
}

And if you want it centered,

.wp-block-audio {
    text-align: center;
}

@paaljoachim
Copy link
Author

paaljoachim commented Nov 6, 2018

I am testing it out. Adding the height makes the player visible.

I also noticed doing an inspect element that this css is already in place:
audio, canvas, img, svg, video {
max-width: 100%;
height: auto;
box-sizing: border-box;
}

Perhaps we need to add a min-height: 50px; to the original Beans CSS code located here:

screen shot 2018-11-06 at 14 48 08

uikit-compiler


I also added the

.wp-block-audio {
    text-align: center;
}

It now looks like this:
screen shot 2018-11-06 at 14 53 39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants