Skip to content

Commit

Permalink
Removed Brave.exe check to support on mac
Browse files Browse the repository at this point in the history
  • Loading branch information
Maheshkale447 committed Oct 28, 2024
1 parent cddccd6 commit f82c455
Showing 1 changed file with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,6 @@ public override string GetDriverConfigsEditPageName(Agent.eDriverType driverSubT
[UserConfiguredDefault("")]
[UserConfiguredDescription("Provide the path to the browser executable.")]
public string BrowserExecutablePath { get; set; }
//"C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe"

[UserConfigured]
[UserConfiguredDefault("false")]//"driver is failing to launch when the mode is true"
Expand Down Expand Up @@ -694,9 +693,8 @@ public override void StartDriver()
//checking the windows 32 and 64 bit version exists or not. if not then user can provide the path mannually.
case eBrowserType.Brave:
ChromeOptions brave_options = new ChromeOptions();
if (BrowserExecutablePath != null && BrowserExecutablePath.Trim().Length > 0 && File.Exists(BrowserExecutablePath) && BrowserExecutablePath.Contains("brave.exe"))
if (BrowserExecutablePath != null && BrowserExecutablePath.Trim().Length > 0 && File.Exists(BrowserExecutablePath))
{

brave_options.BinaryLocation = BrowserExecutablePath;
}
else if (File.Exists(BRAVE_64BIT_BINARY_PATH))
Expand All @@ -710,8 +708,8 @@ public override void StartDriver()
else
{
throw new Exception("The Brave browser path is not available in default path. Please install it or provide the valid executable path in 'Browser Executable Path' parameter in agent configuration.");

}

configChromeDriverAndStart(brave_options);

break;
Expand Down

0 comments on commit f82c455

Please sign in to comment.