From 0a024c1813a6afb1b83ffaaa47abda1b23d31560 Mon Sep 17 00:00:00 2001
From: Giovanni Fulco <giovanni.fulco@gmail.com>
Date: Sun, 2 Jul 2023 18:28:17 +0200
Subject: [PATCH] [BUG] Fix python package installation #196 (#197)

---
 Dockerfile              | 8 ++------
 README.md               | 1 +
 app/bin/run-upmpdcli.sh | 5 ++++-
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/Dockerfile b/Dockerfile
index f13b126..a0610c9 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -26,11 +26,7 @@ RUN apt-get install -y upmpdcli
 RUN apt-get install -y upmpdcli-*
 RUN apt-get install -y python3 
 RUN apt-get install -y python3-pip
-RUN apt-get install -y python3-venv
 RUN apt-get install -y git
-RUN python3 -m venv /root/venv
-RUN PATH=/root/venv/bin:$PATH pip install pyradios
-RUN PATH=/root/venv/bin:$PATH pip install subsonic-connector==0.1.17
 RUN apt-get remove -y software-properties-common
 RUN apt-get -y autoremove
 RUN	rm -rf /var/lib/apt/lists/*
@@ -48,8 +44,8 @@ RUN echo "--- END   upmpdcli.conf ---"
 FROM scratch
 COPY --from=BASE / /
 
-LABEL maintainer="GioF71"
-LABEL source="https://github.com/GioF71/upmpdcli-docker"
+#LABEL maintainer="GioF71"
+#LABEL source="https://github.com/GioF71/upmpdcli-docker"
 
 RUN mkdir -p /app
 RUN mkdir -p /app/conf
diff --git a/README.md b/README.md
index 3cfa9c1..931e773 100644
--- a/README.md
+++ b/README.md
@@ -231,6 +231,7 @@ Just be careful to use the tag you have built.
 
 Change Date|Major Changes
 ---|---
+2023-07-02|Back to installing python packages at container startup (see issue [#196](https://github.com/GioF71/upmpdcli-docker/issues/196))
 2023-06-30|Add support for `lunar` (see issue [#193](https://github.com/GioF71/upmpdcli-docker/issues/193))
 2023-06-30|Remove binary version from image tags (see issue [#190](https://github.com/GioF71/upmpdcli-docker/issues/190))
 2023-06-30|Add entrypoints for inspecting version (see issue [#188](https://github.com/GioF71/upmpdcli-docker/issues/188)
diff --git a/app/bin/run-upmpdcli.sh b/app/bin/run-upmpdcli.sh
index c8836a0..03a6e14 100644
--- a/app/bin/run-upmpdcli.sh
+++ b/app/bin/run-upmpdcli.sh
@@ -441,4 +441,7 @@ echo "Ready to start."
 CMD_LINE="/usr/bin/upmpdcli -c $CONFIG_FILE"
 
 echo "USER MODE (now mandatory)"
-su - $USER_NAME -c "PATH=/root/venv/bin:$PATH $CMD_LINE"
+su - $USER_NAME -c "pip install pyradios"
+su - $USER_NAME -c "pip install subsonic-connector==0.1.17"
+
+su - $USER_NAME -c "$CMD_LINE"