Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated firebase-cocoapods to "11.1.0" #592

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Updated firebase-cocoapods to "11.1.0" #592

merged 1 commit into from
Aug 29, 2024

Conversation

siarhei-luskanau
Copy link
Contributor

No description provided.

@siarhei-luskanau
Copy link
Contributor Author

@Daeda88 Hi, I see you have approved the PR.
This PR contains the compilation error in firebase-auth/src/iosMain/kotlin/dev/gitlive/firebase/auth/auth.kt file. I can't resolve some imports

@Daeda88
Copy link
Contributor

Daeda88 commented Aug 28, 2024

Ill try and have a look to see if I can understand why

@Daeda88
Copy link
Contributor

Daeda88 commented Aug 28, 2024

@siarhei-luskanau I checked out your branch. The reason its failing is because the FIRAuthErrorCode enum was moved to Swift and Kotlin Native is not able to resolve it. I think the only way to solve it is by replacing the enum codes with the actual values https://github.com/firebase/firebase-ios-sdk/blob/2f6ac4c2c61cd57c7ea727009e187b7e1163d613/FirebaseAuth/Sources/Swift/Utilities/AuthErrors.swift#L51

I recall someone ran into a similar issue for another module, but I cannot find it. Maybe @nbransby remembers.

@siarhei-luskanau siarhei-luskanau force-pushed the firebase-cocoapods-11.1.0 branch 2 times, most recently from f4ecdf0 to 7f2abe2 Compare August 29, 2024 09:21
@nbransby nbransby merged commit ba73861 into GitLiveApp:master Aug 29, 2024
50 checks passed
@siarhei-luskanau siarhei-luskanau deleted the firebase-cocoapods-11.1.0 branch August 29, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daeda88 Daeda88 Daeda88 approved these changes

@nbransby nbransby nbransby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siarhei-luskanau @Daeda88 @nbransby