Skip to content
This repository has been archived by the owner on Feb 12, 2023. It is now read-only.

Argument.IsNotNullOrEmpty(nameof(path), path) thrown #207

Open
etalon opened this issue Jan 11, 2019 · 4 comments
Open

Argument.IsNotNullOrEmpty(nameof(path), path) thrown #207

etalon opened this issue Jan 11, 2019 · 4 comments

Comments

@etalon
Copy link

etalon commented Jan 11, 2019

The GetNormalizedPath-Function is called with an empty path.
I don't know why an empty path is passed an not filtered.

I tried removing empty paths in Linker.Link-Function and then it worked but I don't want to push this.

I call GitLink.exe with the following arguments:
$arguments = $pathToPdb + " --baseDir " + $workingDir + " --url " + $url

PS: A new release would be fine. Thanks for your efforts.

@GeertvanHorrik
Copy link
Contributor

Interested in doing a PR?

@etalon
Copy link
Author

etalon commented Jan 19, 2019

Sorry, what is a PR?

@GeertvanHorrik
Copy link
Contributor

PR stands for Pull Request.

@etalon
Copy link
Author

etalon commented Feb 1, 2019

Thanks, sure. My changes in the code are working, but I didn't solve the problem from the root. So I don't want to push this. Someone who knows the code in detail can say where these empty paths come from.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants