Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CLI parameter to pass custom values for variables #255

Open
akordowski opened this issue Jul 24, 2020 · 4 comments
Open

Add a CLI parameter to pass custom values for variables #255

akordowski opened this issue Jul 24, 2020 · 4 comments
Assignees
Labels
Milestone

Comments

@akordowski
Copy link
Contributor

Add a CLI parameter to pass custom values for placeholder variables.

Detailed Description

With a CLI parameter custom values could be passed to replace placeholder variables in a text.

Context

In the current yaml config it is only possible to use current owner, repository, milestone variables as placeholder. E.g. in the config close: issue-comment property the {milestone} placeholder is used for the version number. As below defined (example from the Cake project) the links wouldn't work, because the valid v0.1.0 milestone is not a valid version number for the NuGet or Chocolatey packages. So it be good to have a parameter to pass custom values for placeholder.

- [GitHub Release](https://github.com/{owner}/{repository}/releases/tag/{milestone})
- [NuGet Package](https://www.nuget.org/packages/Cake/{milestone})
- [Chocolatey Package](https://chocolatey.org/packages/cake.portable/{milestone})
- [.Net Global Tool](https://www.nuget.org/packages/Cake.Tool/{milestone})

Possible Implementation

I suggest following implementation

  • --variables var1=value1;var2=value2
    A semicolon or comma separated list of variables wit values
  • Or as a alternative --placeholders var1=value1;var2=value2

I would like to implement the changes and provide a PR.

@gep13
Copy link
Member

gep13 commented Jul 25, 2020

@akordowski this sounds like a great addition to me!

@akordowski
Copy link
Contributor Author

Great, then I will go to work the next days.

@gep13
Copy link
Member

gep13 commented Jul 30, 2020

@akordowski I really think that this is a good idea, so I would be happy if you wanted to spend some time implementing this.

@gep13
Copy link
Member

gep13 commented Apr 19, 2021

While I think this is a good idea, I don't want to hold up the next release while waiting on this to be implemented, so going to move this to a future milestone.

@gep13 gep13 modified the milestones: 0.12.0, Future Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants