Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unit test conventions consistent #277

Open
gep13 opened this issue Aug 25, 2020 · 5 comments
Open

Make unit test conventions consistent #277

gep13 opened this issue Aug 25, 2020 · 5 comments

Comments

@gep13
Copy link
Member

gep13 commented Aug 25, 2020

Some unit test have the method format ThisIsATest() and others This_Is_A_Test().

@gep13
Copy link
Member Author

gep13 commented Aug 25, 2020

@akordowski @AdmiringWorm I have no real opinion on this either way. Which one would we prefer?

@akordowski
Copy link
Contributor

I prefer This_Is_A_Test(). On long method names this is better readable.

@gep13
Copy link
Member Author

gep13 commented Aug 25, 2020

@akordowski this comment isn't related to this issue, is it?

@AdmiringWorm
Copy link
Member

I agree with @akordowski in this.
Having underscores in the unit test names make them more readable, but this would require a change in the StyleCop rules (I think).

@gep13
Copy link
Member Author

gep13 commented Aug 26, 2020

So, sounds like This_Is_A_Test() is the winner. No objections from me in adopting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants