From 996310ba1408fe746c6de43cb24dc1e809fd4d57 Mon Sep 17 00:00:00 2001 From: Sebastian Thiel Date: Sat, 13 Apr 2024 11:10:23 +0200 Subject: [PATCH] refactor `gix-transport` with minor edits to comments --- gix-transport/src/client/blocking_io/ssh/mod.rs | 2 +- gix-transport/src/client/blocking_io/ssh/program_kind.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gix-transport/src/client/blocking_io/ssh/mod.rs b/gix-transport/src/client/blocking_io/ssh/mod.rs index 9e5effb471d..6820051a5ec 100644 --- a/gix-transport/src/client/blocking_io/ssh/mod.rs +++ b/gix-transport/src/client/blocking_io/ssh/mod.rs @@ -124,7 +124,7 @@ pub fn connect( Usable(host) => host, Dangerous(host) => Err(Error::AmbiguousHostName { host: host.into() })?, Absent => panic!("BUG: host should always be present in SSH URLs"), - }), // We omit `user@` with `-G`, so it need not be safe here, but host must be safe. + }), ); gix_features::trace::debug!(cmd = ?cmd, "invoking `ssh` for feature check"); kind = if cmd.status().ok().map_or(false, |status| status.success()) { diff --git a/gix-transport/src/client/blocking_io/ssh/program_kind.rs b/gix-transport/src/client/blocking_io/ssh/program_kind.rs index 7c6f5c8a157..d7162c09b33 100644 --- a/gix-transport/src/client/blocking_io/ssh/program_kind.rs +++ b/gix-transport/src/client/blocking_io/ssh/program_kind.rs @@ -72,9 +72,9 @@ impl ProgramKind { (_, Absent) => panic!("BUG: host should always be present in SSH URLs"), }; - // Try to force ssh to yield English messages (for parsing later). Ok(prepare .arg(host_maybe_with_user_as_ssh_arg) + // Try to force ssh to yield English messages (for parsing later). .env("LANG", "C") .env("LC_ALL", "C")) }