Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement timer "cooldown" to email verification email request #4890

Closed
divine-comedian opened this issue Dec 4, 2024 · 18 comments
Closed
Assignees
Labels
email issues related to emails

Comments

@divine-comedian
Copy link
Contributor

In some scenarios it can take more than 2 minutes for an email containing the verification code to arrive in a user's inbox. In this case a user may doubt if the button is working properly, clicking the button to send the code many times. each one triggering a new email & code to be sent.

In order to prevent this we should add a countdown timer of 3 minutes that the user must wait until for them to request another code to be sent.

Image

Screencast.from.2024-12-03.10-47-20.webm
@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Dec 4, 2024
@divine-comedian divine-comedian moved this from New Issues to Design in All-Devs Dec 4, 2024
@Tosinolawale
Copy link

with timer
After countdown
https://www.figma.com/design/vMiyVd1Ly5LjgSyZrChVV8/Giveth-users?node-id=3141-9604&t=kG010GKaHGMW36sB-1
@divine-comedian

@Tosinolawale
Copy link

Timer.webm

@divine-comedian
Copy link
Contributor Author

@Tosinolawale what happens when the user tries to click the link while the timer is active? is it disabled? do we show a warning toast message?

do we have any confirmation toast as well when the user clicks to resend verification link?

@Tosinolawale
Copy link

Tosinolawale commented Dec 5, 2024

@Tosinolawale what happens when the user tries to click the link while the timer is active? is it disabled? do we show a warning toast message?

do we have any confirmation toast as well when the user clicks to resend verification link?

From the design there, the link is disabled.. it's greyed out while the timer is active. I also explained it in the figma file and there is no need to show a warning toast message. The count down and inactive link is sufficient to convey that message

@divine-comedian
Copy link
Contributor Author

@Tosinolawale what happens when the user tries to click the link while the timer is active? is it disabled? do we show a warning toast message?
do we have any confirmation toast as well when the user clicks to resend verification link?

From the design there, the link is disabled.. it's greyed out while the timer is active. I also explained it in the figma file and there is no need to show a warning toast message. The count down and inactive link is sufficient to convey that message

Got it! Yep looked at the figma 😅 looks great 🙌

@divine-comedian divine-comedian moved this from Design to Dev Research in All-Devs Dec 5, 2024
@divine-comedian divine-comedian added the email issues related to emails label Dec 5, 2024
@divine-comedian divine-comedian moved this from Dev Research to Product Backlog in All-Devs Jan 6, 2025
@kkatusic kkatusic moved this from Sprint Backlog to In Progress in All-Devs Jan 9, 2025
@kkatusic kkatusic moved this from In Progress to Code Review/PR in All-Devs Jan 9, 2025
@kkatusic kkatusic moved this from Code Review/PR to In Progress in All-Devs Jan 9, 2025
@kkatusic kkatusic moved this from In Progress to QA in All-Devs Jan 10, 2025
@maryjaf
Copy link
Collaborator

maryjaf commented Jan 12, 2025

It hasn't been merged on staging and isn't ready for QA yet

Image

@maryjaf maryjaf moved this from QA to Code Review/PR in All-Devs Jan 12, 2025
@kkatusic
Copy link
Collaborator

Sorry @maryjaf, merged now

@maryjaf
Copy link
Collaborator

maryjaf commented Jan 13, 2025

There is a problem in showing counter @kkatusic

-by tapping on verify email, the counter is shown for a sec after that disappears
-by tapping on resend verification code, the counter is shown for a sec after that disappears

Screen.Recording.2025-01-13.at.1.15.42.PM.mov

@kkatusic
Copy link
Collaborator

@maryjaf you can test it again when you find time, thx

@kkatusic kkatusic moved this from Code Review/PR to QA in All-Devs Jan 13, 2025
@maryjaf
Copy link
Collaborator

maryjaf commented Jan 14, 2025

there seems to be an issue with displaying the timer. Please take a look at the screen recording below: @kkatusic

Screen.Recording.2025-01-14.at.10.18.22.AM.mov

Also, I think the "Resend Verification Code" button should have a different color when the timer is active, so the user can easily recognize that it's disabled.

@divine-comedian
Copy link
Contributor Author

@Tosinolawale

Do you mind making the timer countdown a bit more noticeable based on @maryjaf's feedback - maybe a bit bigger and a distinct colour so it can be seen easily.

@kkatusic
Copy link
Collaborator

@maryjaf I blurred link, thx for that, please can you on next test refresh link and try again. I don't get same problem as you, maybe some old state was inside cache, if you see same problem please can you record all steps ;)

@Tosinolawale
Copy link

Tosinolawale commented Jan 14, 2025

there seems to be an issue with displaying the timer. Please take a look at the screen recording below: @kkatusic

Screen.Recording.2025-01-14.at.10.18.22.AM.mov
Also, I think the "Resend Verification Code" button should have a different color when the timer is active, so the user can easily recognize that it's disabled.

From the design itself, "Resend Verification Code" IS a different color when the timer is active.
with value
with value 2

Different Color tones from the color styles @maryjaf

@Tosinolawale
Copy link

@Tosinolawale

Do you mind making the timer countdown a bit more noticeable based on @maryjaf's feedback - maybe a bit bigger and a distinct colour so it can be seen easily.

counter
https://www.figma.com/design/vMiyVd1Ly5LjgSyZrChVV8/Giveth-users?node-id=3141-9604&t=KbsceyEfnR0TJjF8-1
@divine-comedian @maryjaf

@maryjaf
Copy link
Collaborator

maryjaf commented Jan 15, 2025

Different Color tones from the color styles @maryjaf

Thanks Guys, this problem has been fixed.

But As you can see in the screen recording below, when the timer starts for the first time, everything works correctly. However, when I tap on "Resend Verification Email" and the timer restarts, the displayed numbers appear glitchy @kkatusic

Screen.Recording.2025-01-15.at.10.40.49.AM.mov

@maryjaf maryjaf moved this from QA to In Progress in All-Devs Jan 19, 2025
@kkatusic kkatusic moved this from In Progress to QA in All-Devs Jan 20, 2025
@kkatusic
Copy link
Collaborator

@maryjaf when you find time you can test it again ;)

@maryjaf
Copy link
Collaborator

maryjaf commented Jan 21, 2025

But As you can see in the screen recording below, when the timer starts for the first time, everything works correctly. However, when I tap on "Resend Verification Email" and the timer restarts, the displayed numbers appear glitchy @kkatusic

Thanks @kkatusic this problem has been fixed.

@maryjaf maryjaf moved this from QA to Done in All-Devs Jan 21, 2025
@kkatusic
Copy link
Collaborator

Thx to you @maryjaf ;)

@divine-comedian divine-comedian moved this from Done to Merged to Production in All-Devs Jan 29, 2025
@divine-comedian divine-comedian closed this as completed by moving to Merged to Production in All-Devs Jan 29, 2025
@github-project-automation github-project-automation bot moved this from Merged to Production to Done in All-Devs Jan 29, 2025
@divine-comedian divine-comedian moved this from Done to Merged to Production in All-Devs Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
email issues related to emails
Projects
Status: Merged to Production
Development

No branches or pull requests

4 participants