Create a project bug - Error messaging saying that my address is being used for another project, but it isn't/shouldn't be

[laurenluz]

I was editing the Giveth project.
First, I made edits and then published. Then, I realized there was a mistake, so went to make one more edit in the body again (while it was unlisted).
After editing the body, I wasn't able to "publish" because now it claimed that my address giv.eth was being used for another project - but I didn't change the address, so that's impossible.

I think there is an issue happening somehow where if the project is unlisted, our checks on the address are bugging out.

cc @divine-comedian

[divine-comedian]

@laurenluz if you made the edits, published, listed it in the admin again then made edits again (causing it to become unlisted) then the error above did not occur?

[kkatusic]

@laurenluz, cc @divine-comedian, I found one project that is using same address for Arbitrum network: https://giveth.io/project/1-0?tab=donations

[laurenluz]

I tried again, and actually, yeah, I have the same issue even if it's listed.
however, I didn't have this issue the FIRST time I pushed the edit. on the 2nd time...

A fix that would help: that project @kkatusic you mentioned is inactive. projects that are inactive should not conflict with active projects if they have the same address.

There are more issues on create a project happening too wrt to this image thing:

For example:

• when I add an image, for no reason at all, it just shows me it blurry. sometimes this doesn't happen with the same image.
• the bounds of the image go beyond the bounds of the editing box

Screen.Recording.2025-01-03.at.5.22.54.PM.mov

[kkatusic]

@laurenluz we didn't fix issue, I just wrote what is problem is, same address on some project, let's ask @divine-comedian what behaviour I will use to solve this:

• remove wallet address from that project and add new one on it?
• remove that project?
• write code that will exclude checking address on project that are inactive?

or you can always propose some better solution and I will implement it.

@laurenluz I will check this image issue inside editor, just one notice here, that editor should be updated to newest version but we have some problem with its dependencies.

[kkatusic]

@laurenluz I checked image behaviours inside editor, blurred image is showing you that is process of the uploading same in progress, take some time for the larger images.

The bounds go outside like you wrote, we need to check editor update does same behaviour has been fixed.

[laurenluz]

@kkatusic I think the best solution for the address issue is the 3rd one: write code that will exclude checking address on project that are inactive.

Projects become inactive when the project owner decides to do it. They may one day want to come back to reactivate it. Likely not, but possible.

did you already upgrade the image editor?

[divine-comedian]

@kkatusic I think the best solution for the address issue is the 3rd one: write code that will exclude checking address on project that are inactive.

Projects become inactive when the project owner decides to do it. They may one day want to come back to reactivate it. Likely not, but possible.

did you already upgrade the image editor?

I don't think this is a good idea, since we will run into issues if/when a project chooses to reactivate, this can be done arbitrarily by the user at anytime and we will run into issues later on trying to fix that bug.

Looking at this project conflict specifically I think it is safe to remove the address from https://giveth.io/project/1-0?tab=donations and we can replace it with the same address they have used on all other chains -> 0x882a8CA69f4ae29271816837FD12b144d60f8fA7

[divine-comedian]

I tried again, and actually, yeah, I have the same issue even if it's listed. however, I didn't have this issue the FIRST time I pushed the edit. on the 2nd time...

A fix that would help: that project @kkatusic you mentioned is inactive. projects that are inactive should not conflict with active projects if they have the same address.

There are more issues on create a project happening too wrt to this image thing:

For example:

• when I add an image, for no reason at all, it just shows me it blurry. sometimes this doesn't happen with the same image.
• the bounds of the image go beyond the bounds of the editing box

Screen.Recording.2025-01-03.at.5.22.54.PM.mov

I follow up this issue here- > #4925

[laurenluz]

I don't think this is a good idea, since we will run into issues if/when a project chooses to reactivate, this can be done arbitrarily by the user at anytime and we will run into issues later on trying to fix that bug.

We should just plan for that within the flow. When they try to reactivate - if someone else used that address for another project - they could get some message like: "oops, that address is being used by another project. change the recipient address in order to reactivate the project". and ofc, we'd need to allow people to edit inactive projects.

If we do anything to address it, there would need to be some user flow designed for it. removing wallet addresses might confuse people, and removing the project when someone sets it as inactive is not really a good option because as you said, someone might even do this by accident.

[divine-comedian]

I don't think this is a good idea, since we will run into issues if/when a project chooses to reactivate, this can be done arbitrarily by the user at anytime and we will run into issues later on trying to fix that bug.

We should just plan for that within the flow. When they try to reactivate - if someone else used that address for another project - they could get some message like: "oops, that address is being used by another project. change the recipient address in order to reactivate the project". and ofc, we'd need to allow people to edit inactive projects.

If we do anything to address it, there would need to be some user flow designed for it. removing wallet addresses might confuse people, and removing the project when someone sets it as inactive is not really a good option because as you said, someone might even do this by accident.

I think this will create more complexities especially in the back-end where we store the project data. The impact-graph is a very fickle beast these days.

We noticed that this validation of checking existing recipient addresses should have been happening more consistently and for some reason it only started working recently - even though the code remained unchanged for 3 years...

The quickest and most direct solution is to edit the project data that is interfering with updating the Giveth project and let's keep a close eye if similar issues are being reported by users. If so we might have to focus on finding a more complex solution.

[laurenluz]

sounds good. so @kkatusic maybe just remove the giv.eth address from that (inactive) project...

But worth noting that also, when I created the issue initially... those addresses were used for the giveth project already (I didn't edit them for a long long time) so there was some error in our system prior to me creating the issue that led to the duplication in the first place.

[divine-comedian]

sounds good. so @kkatusic maybe just remove the giv.eth address from that (inactive) project...

But worth noting that also, when I created the issue initially... those addresses were used for the giveth project already (I didn't edit them for a long long time) so there was some error in our system prior to me creating the issue that led to the duplication in the first place.

Exactly, that's the confusing bit is that some piece of code that hasn't been touched for 3 years is now working, when maybe it wasn't working for... god knows how long

So far I've only heard of this issue from you and Maryjaf cause she has like 3581945197651056914 test projects

[kkatusic]

@laurenluz, cc @divine-comedian, I changed address to that project, setup same main address that project has. Please can you try when you find the time to edit Giveth project and try to save updates.

About how first time you saved changes with no problem, we are investigating that. Some changes can be done via administration. Only connection that we found was that that's address didn't have userId linked.

[maryjaf]

I’m encountering an error on https://giveth.io/project/maryam-test. Could you please apply the same change that you made to the Giveth project to this project as well, so I can test it? @kkatusic

[kkatusic]

I’m encountering an error on https://giveth.io/project/maryam-test. Could you please apply the same change that you made to the Giveth project to this project as well, so I can test it? @kkatusic

@maryjaf done. Please test it when you find time.

[maryjaf]

Thanks , it has been fixed for me