Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User is sent automatically to next step after connecting one account to givbacks form #4924

Closed
4 tasks
divine-comedian opened this issue Jan 6, 2025 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@divine-comedian
Copy link
Contributor

divine-comedian commented Jan 6, 2025

After connecting one account, the user is redirected to the next step. Is this behavior acceptable? @divine-comedian

Screen.Recording.2025-01-06.at.10.26.54.AM.mov

Originally posted by @maryjaf in #4493 (comment)

While on the givbacks eligiblity form the user has the option to connect linkedIn, Discord and Twitter, they can connect none or all 3, it is optional. However it appears when a user connects an account the form automatically sends them to the next step,

The expected behaviour is that the user stays on this page so they can see their account has been successfully linked and can add more connections if they wish.

AC

  • when user makes OAuth social media connection on givbacks form user remains on same step of the form
  • user can successfully add other social media connections and still remains on same step of the form
  • user can successfully submit givbacks eligiblity form
  • user can successfully remove social media connection and remains on same step of the form
@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Jan 6, 2025
@divine-comedian divine-comedian moved this from New Issues to Dev Research in All-Devs Jan 6, 2025
@divine-comedian divine-comedian added the bug Something isn't working label Jan 6, 2025
@maryjaf
Copy link
Collaborator

maryjaf commented Jan 7, 2025

If needed , I think I can work on it @divine-comedian

@divine-comedian
Copy link
Contributor Author

divine-comedian commented Jan 7, 2025

take it! 😄

Please based on our sprint planning exercise today can you provide a size to this issue

image

@divine-comedian divine-comedian moved this from Dev Research to Product Backlog in All-Devs Jan 7, 2025
@maryjaf maryjaf moved this from Product Backlog to In Progress in All-Devs Jan 8, 2025
@maryjaf maryjaf moved this from In Progress to Code Review/PR in All-Devs Jan 9, 2025
@divine-comedian divine-comedian moved this from Code Review/PR to QA in All-Devs Jan 15, 2025
@divine-comedian
Copy link
Contributor Author

@LatifatAbdullahi this should be ready to test

@LatifatAbdullahi
Copy link

LatifatAbdullahi commented Jan 16, 2025

Test Update @divine-comedian

Thanks @maryjaf

  • When user makes OAuth social media connection on givbacks form user remains on same step of the form - Pass
  • User can successfully add other social media connections and still remains on same step of the form - Pass
  • User can successfully submit givbacks eligiblity form - Pass
  • User can successfully remove social media connection and remains on same step of the form - Pass
GIVbacks.Eligibility.Application._.Giveth.-.Google.Chrome.2025-01-16.09-57-32.mp4

Issue
@maryjaf

In a Scenario where Users have deleted already added Social Media accounts and decide to add them back, it displays a message that they have already added social media accounts (even when its deleted).
Users are only able to add again when they refresh the page.

GIVbacks.Eligibility.Application._.Giveth.-.Google.Chrome.2025-01-16.09-51-19.mp4

image

@maryjaf
Copy link
Collaborator

maryjaf commented Jan 16, 2025

n a Scenario where Users have deleted already added Social Media accounts and decide to add them back, it displays a message that they have already added social media accounts (even when its deleted).
Users are only able to add again when they refresh the page.

Great, Thanks @LatifatAbdullahi
Yeah I saw That but I think it's related to issue about remove social media link , if we have already an issue for this we can resolve this problem on that issue or create a separate issue "

cc: @divine-comedian

@LatifatAbdullahi
Copy link

LatifatAbdullahi commented Jan 16, 2025

@divine-comedian

Thanks @maryjaf

A separate issue has been created for it #4939

@LatifatAbdullahi LatifatAbdullahi moved this from QA to Done in All-Devs Jan 16, 2025
@divine-comedian divine-comedian moved this from Done to Merged to Production in All-Devs Jan 29, 2025
@divine-comedian divine-comedian closed this as completed by moving to Merged to Production in All-Devs Jan 29, 2025
@github-project-automation github-project-automation bot moved this from Merged to Production to Done in All-Devs Jan 29, 2025
@divine-comedian divine-comedian moved this from Done to Merged to Production in All-Devs Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Merged to Production
Development

No branches or pull requests

3 participants