-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use consistently count
and indexes
for band listing and counting (removing nbands
and bands
)
#346
Use consistently count
and indexes
for band listing and counting (removing nbands
and bands
)
#346
Conversation
…ent with rasterio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully it will be much clearer now!
But what I don't get is that basically here you just removed nbands into count and bands into indexes. But I thought we had a different use of count and nbands, depending on what was loaded and what was on disk, no?
In the issue, I suggested using a count_loaded
and indexes_loaded
but it seems like it was not needed, why?
My bad, I forgot that point! I added them back and added tests for them. The names |
Sounds good. Everything seems perfect now, thanks ! |
To be fully consistent with
rasterio
.Resolves #280