Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make raster_equal accept False mask values of masked arrays #468

Merged
merged 8 commits into from
Feb 4, 2024

Conversation

rhugonnet
Copy link
Contributor

And fixes test_save in TestMask, the difference came from the fact that in-memory rasters don't necessarily have the same masked .data.data as the ones read from disk, as they are replaced by the nodata value when writing.

Resolves #466

@rhugonnet
Copy link
Contributor Author

All passing locally, need to wait for the Segmentation Fault issue of Pytest to be solved for CI...

Copy link
Member

@adehecq adehecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! All good.

@rhugonnet rhugonnet merged commit 4411f1b into GlacioHack:main Feb 4, 2024
13 checks passed
@rhugonnet rhugonnet deleted the fix_mask_save branch February 4, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mask read from file is slightly different than saved Mask
2 participants