Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong results for TPCH benchmarks when using native storage format #1834

Closed
djouallah opened this issue Sep 26, 2023 · 5 comments · Fixed by #1847
Closed

Wrong results for TPCH benchmarks when using native storage format #1834

djouallah opened this issue Sep 26, 2023 · 5 comments · Fixed by #1847
Assignees
Labels
bug Something isn't working

Comments

@djouallah
Copy link

Glaredb seems to not to return results at all for some queries when using Native format

https://colab.research.google.com/drive/11Jz3G1oqf8glye5BmNIq5cOdeUQJjImv#scrollTo=MDTt42NXEL5_

@djouallah djouallah added the bug Something isn't working label Sep 26, 2023
@scsmithr
Copy link
Member

@universalmind303 can you look at this?

@universalmind303
Copy link
Contributor

universalmind303 commented Sep 26, 2023

looks like something weird is going on with date math

this return an empty result set

select l_shipdate from lineitem where l_shipdate > date '1995-03-09';

but an explicit cast seems to work

select l_shipdate from lineitem where l_shipdate::timestamp > date '1995-03-09';

trying to figure out why the date math isn't working for Date32 dtype in delta format

@djouallah
Copy link
Author

btw, it does works fine with parquet, I suspect the issue is happening when I convert parquet to delta

https://colab.research.google.com/drive/1_iD6S6MR88B1Ym91pXksmtqaQzF4seQa#scrollTo=S2iF1xWKUXF7

@universalmind303
Copy link
Contributor

@djouallah it appears to be an issue with the delta-rs library. We'll work on getting it fixed upstream!

please refer to delta-io/delta-rs#1670 if you want to track the progress.

@universalmind303 universalmind303 linked a pull request Sep 28, 2023 that will close this issue
@scsmithr
Copy link
Member

@djouallah this has been fixed and is included in the latest 0.5.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants