diff --git a/.eslintignore b/.eslintignore index 7e45de312a..2de71925e4 100644 --- a/.eslintignore +++ b/.eslintignore @@ -1,2 +1,5 @@ # Contains the PDF file of the Tag as JSON string, thus does not need to be linted -src/components/CheckIn/tagTemplate.ts \ No newline at end of file +src/components/CheckIn/tagTemplate.ts +package.json +package-lock.json +tsconfig.json diff --git a/.eslintrc.json b/.eslintrc.json index b3704d9aa1..165e406024 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -5,7 +5,6 @@ "es6": true }, - // Specify the rulesets from other ESLint Plugins tobe used "extends": [ "plugin:react/recommended", "eslint:recommended", @@ -28,7 +27,6 @@ "sourceType": "module" }, - // Specify the ESLint plugins tobe used "plugins": [ "react", "@typescript-eslint", @@ -78,13 +76,13 @@ "camelcase": "off", "@typescript-eslint/naming-convention": [ "error", - // Interfaces must begin with Interface or TestInterface followed by a PascalCase name + { "selector": "interface", "format": ["PascalCase"], "prefix": ["Interface", "TestInterface"] }, - // Type Aliases must be in PascalCase + { "selector": ["typeAlias", "typeLike", "enum"], "format": ["PascalCase"] @@ -121,20 +119,17 @@ "format": null } ], - // Ensures that components are always written in PascalCase + "react/jsx-pascal-case": [ "error", { "allowAllCaps": false, "allowNamespace": false } ], - // Enforces whitespace around equal sign operators "react/jsx-equals-spacing": ["warn", "never"], "react/no-this-in-sfc": "error", - // All tests must need not have an assertion "jest/expect-expect": 0, - // Enforce Strictly functional components "react/no-unstable-nested-components": ["error", { "allowAsProps": true }], "react/function-component-definition": [ 0, @@ -143,10 +138,10 @@ "prettier/prettier": "error" }, - // Let ESLint use the react version in the package.json "settings": { "react": { "version": "detect" } - } + }, + "ignorePatterns": ["**/*.css", "**/*.scss", "**/*.less", "**/*.json"] } diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index a1e203bfdf..0748858133 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,3 +1,4 @@ +